Bug 47159 – CSS 2.1 failure: background-position-201, background-position-202

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Simon Fraser (smfr)]

Created attachment 69754 [details]
background-position-202.htm

These tests fail:

html4/background-position-201	fail
html4/background-position-202	fail

[Simon Fraser (smfr)]

The bug seems to be that we parse background-position: bottom 100%; as valid, when the spec says:
"If at least one value is not a keyword, then the first value represents the horizontal position and the second represents the vertical position".
http://www.w3.org/TR/CSS21/colors.html#propdef-background-position

[Dave Hyatt]

Created attachment 85503 [details]
Patch

[WebKit Review Bot]

Attachment 85503 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast..." exit_code: 1

Source/WebCore/css/CSSParser.cpp:2579:  An else should appear on the same line as the preceding }  [whitespace/newline] [4]
Source/WebCore/css/CSSParser.cpp:2627:  One line control clauses should not use braces.  [whitespace/braces] [4]
Total errors found: 2 in 17 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Simon Fraser (smfr)]

Comment on attachment 85503 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=85503&action=review

> Source/WebCore/css/CSSParser.h:93
> +        enum FillPositionFlag { InvalidFillPosition = 0, AmbiguousFillPosition = 1, XFillPosition = 2, YFillPosition = 4 };

If this is a bitmask I'd prefer to see 0, 1 << 0, 1 << 1, 1 << 2

[Dave Hyatt]

Fixed in r80868.

[Build Bot]

Attachment 85503 [details] did not build on win:
Build output: http://queues.webkit.org/results/8135376

[Andreas Kling]

*** Bug 41201 has been marked as a duplicate of this bug. ***

[WebKit Review Bot]

http://trac.webkit.org/changeset/80868 might have broken Windows Release (Build) and Windows Debug (Build)