Bug 47140 – new-run-webkit-tests: Chromium DRT broke in r68792

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Dirk Pranke]

The change in r68792 "fixed" the unit tests for new-run-webkit-tests running under Cygwin (see https://bugs.webkit.org/show_bug.cgi?id=46890), but actually broke the Chromium DRT code when it changed the way we were converting local filenames to URLs.

See, for example: http://build.webkit.org/builders/Chromium%20Win%20Release%20(Tests)/builds/3641/steps/layout-test/logs/stdio

[Dirk Pranke]

Created attachment 69733 [details]
Patch

[Adam Barth]

Comment on attachment 69733 [details]
Patch

Beautiful.

[Dirk Pranke]

Comment on attachment 69733 [details]
Patch

Clearing flags on attachment: 69733

Committed r69065: <http://trac.webkit.org/changeset/69065>

[Dirk Pranke]

All reviewed patches have been landed.  Closing bug.

[Dirk Pranke]

For the record, IE, Firefox, Safari, Chrome, and Opera all use the syntax:

file:///c:/foo/bar.txt

to refer to files in the local filesystem on windows (like c:\foo\bar.txt), although Opera canonicalizes it to  file://localhost/c:/foo/bar.txt .

On unix-y systems, all browsers use the syntax:

file:///foo/bar.txt

to refer to /foo/bar.txt

For files on SMB shares, every browser but FF recognizes:

file://host/foo/bar.txt

for \\host\foo\bar.txt. FF unfortunately seems to only recognize file://///host/foo/bar.txt (yes, five slashes), which every browser but Opera recognizes.

(where "canonicalization" is what you get if you print out document.location).