Bug 47140 - new-run-webkit-tests: Chromium DRT broke in r68792
Summary: new-run-webkit-tests: Chromium DRT broke in r68792
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Dirk Pranke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-04 20:53 PDT by Dirk Pranke
Modified: 2010-10-07 12:50 PDT (History)
3 users (show)

See Also:


Attachments
Patch (9.03 KB, patch)
2010-10-04 21:12 PDT, Dirk Pranke
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Pranke 2010-10-04 20:53:40 PDT
The change in r68792 "fixed" the unit tests for new-run-webkit-tests running under Cygwin (see https://bugs.webkit.org/show_bug.cgi?id=46890), but actually broke the Chromium DRT code when it changed the way we were converting local filenames to URLs.

See, for example: http://build.webkit.org/builders/Chromium%20Win%20Release%20(Tests)/builds/3641/steps/layout-test/logs/stdio
Comment 1 Dirk Pranke 2010-10-04 21:12:23 PDT
Created attachment 69733 [details]
Patch
Comment 2 Adam Barth 2010-10-04 21:14:48 PDT
Comment on attachment 69733 [details]
Patch

Beautiful.
Comment 3 Dirk Pranke 2010-10-04 21:19:26 PDT
Comment on attachment 69733 [details]
Patch

Clearing flags on attachment: 69733

Committed r69065: <http://trac.webkit.org/changeset/69065>
Comment 4 Dirk Pranke 2010-10-04 21:19:31 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Dirk Pranke 2010-10-07 12:50:40 PDT
For the record, IE, Firefox, Safari, Chrome, and Opera all use the syntax:

file:///c:/foo/bar.txt

to refer to files in the local filesystem on windows (like c:\foo\bar.txt), although Opera canonicalizes it to  file://localhost/c:/foo/bar.txt .

On unix-y systems, all browsers use the syntax:

file:///foo/bar.txt

to refer to /foo/bar.txt

For files on SMB shares, every browser but FF recognizes:

file://host/foo/bar.txt

for \\host\foo\bar.txt. FF unfortunately seems to only recognize file://///host/foo/bar.txt (yes, five slashes), which every browser but Opera recognizes.

(where "canonicalization" is what you get if you print out document.location).