Bug 47139 – Relax restrictions on FileWriter::didWrite calls

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Eric U.]

Currently we ASSERT that we'll always receive bytes in a didWrite call, and that we'll always get complete==true if we've gotten all the bytes in our request.  This unnecessarily constrains the implementation: if the backend is just reading from the blob until it runs out, it might send the last bytes without knowing that it's done, then send a zero-length completion message.

[Eric U.]

Created attachment 69731 [details]
Patch

[Kinuko Yasuda]

Comment on attachment 69731 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=69731&action=review

> WebCore/fileapi/FileWriter.cpp:97
> +        ec = INVALID_ACCESS_ERR;

INVALID_ACCESS_ERR is not defined as a FileError -- maybe INVALID_STATE_ERR?

[Eric U.]

(In reply to comment #2)
> (From update of attachment 69731 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=69731&action=review
> 
> > WebCore/fileapi/FileWriter.cpp:97
> > +        ec = INVALID_ACCESS_ERR;
> 
> INVALID_ACCESS_ERR is not defined as a FileError -- maybe INVALID_STATE_ERR?

It's not really an invalid state; you passed in a bad parameter.  Perhaps SYNTAX_ERR?  We can always suggest that it go into the spec [which currently doesn't talk about how to respond to a null Blob].

[Kinuko Yasuda]

Comment on attachment 69731 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=69731&action=review

>>> WebCore/fileapi/FileWriter.cpp:97
>>> +        ec = INVALID_ACCESS_ERR;
>> 
>> INVALID_ACCESS_ERR is not defined as a FileError -- maybe INVALID_STATE_ERR?
> 
> It's not really an invalid state; you passed in a bad parameter.  Perhaps SYNTAX_ERR?  We can always suggest that it go into the spec [which currently doesn't talk about how to respond to a null Blob].

If we're given null or undefined where we expect Blob, I think TYPE_MISMATCH_ERR would be applicable.

[Eric U.]

(In reply to comment #4)
> (From update of attachment 69731 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=69731&action=review
> 
> >>> WebCore/fileapi/FileWriter.cpp:97
> >>> +        ec = INVALID_ACCESS_ERR;
> >> 
> >> INVALID_ACCESS_ERR is not defined as a FileError -- maybe INVALID_STATE_ERR?
> > 
> > It's not really an invalid state; you passed in a bad parameter.  Perhaps SYNTAX_ERR?  We can always suggest that it go into the spec [which currently doesn't talk about how to respond to a null Blob].
> 
> If we're given null or undefined where we expect Blob, I think TYPE_MISMATCH_ERR would be applicable.

Yeah, that sounds good.  I'll change it.

[David Levin]

Comment on attachment 69731 [details]
Patch

Per discussion in bug. Other than that it seems fine.

[Eric U.]

Created attachment 69807 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 69807 [details]
Patch

Clearing flags on attachment: 69807

Committed r69140: <http://trac.webkit.org/changeset/69140>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.