WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
47138
Add MIMEType accessor to WKFrame
https://bugs.webkit.org/show_bug.cgi?id=47138
Summary
Add MIMEType accessor to WKFrame
Sam Weinig
Reported
2010-10-04 19:09:11 PDT
Add MIMEType accessor to WKFrame
Attachments
Patch
(74.38 KB, patch)
2010-10-04 19:11 PDT
,
Sam Weinig
mrowe
: review+
abarth
: commit-queue-
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Sam Weinig
Comment 1
2010-10-04 19:11:21 PDT
Created
attachment 69730
[details]
Patch
Sam Weinig
Comment 2
2010-10-04 19:12:43 PDT
<
rdar://problem/8347683
>
WebKit Review Bot
Comment 3
2010-10-04 19:13:50 PDT
Attachment 69730
[details]
did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebKitTools/TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:26: Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] WebKitTools/TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:28: Alphabetical sorting problem. [build/include_order] [4] WebKitTools/TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:31: Alphabetical sorting problem. [build/include_order] [4] WebKitTools/TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:26: Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] WebKitTools/TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:28: Alphabetical sorting problem. [build/include_order] [4] WebKitTools/TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:31: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 6 in 16 files If any of these errors are false positives, please file a bug against check-webkit-style.
Mark Rowe (bdash)
Comment 4
2010-10-04 21:33:18 PDT
Comment on
attachment 69730
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=69730&action=review
> WebKit2/WebKit2.xcodeproj/project.pbxproj:1990 > + developmentRegion = English;
Please don’t land this. You’re not otherwise modifying this project file. r=me
Sam Weinig
Comment 5
2010-10-05 09:47:55 PDT
Landed in
r69116
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug