I am trying to focus a window in the onclick handler for a notification, but it fails because WebKit doesn't think notification.onclick is a user gesture. The problem is that Event::fromUserGesture() is returning false because UserGestureIndicator::processingUserGesture() is returning false. I think the fix is to add a line like this to WebNotification::dispatchClickEvent(): UserGestureIndicator gestureIndicator(DefinitelyProcessingUserGesture); I have a patch locally that does this which I'll try out tomorrow. I can make this change for the qt client also - is there any place else I need to touch?
Created attachment 69799 [details] Updated chromium and qt notification implementations to mark click events as user gestures.
Thank you for fixing it for Qt. Looks good to me (but I am not a reviewer :-)
Patch looks good for chromium too (also not a reviewer).
Comment on attachment 69799 [details] Updated chromium and qt notification implementations to mark click events as user gestures. LGTM, too. Thanks Yael and John!
Comment on attachment 69799 [details] Updated chromium and qt notification implementations to mark click events as user gestures. Clearing flags on attachment: 69799 Committed r69143: <http://trac.webkit.org/changeset/69143>
All reviewed patches have been landed. Closing bug.