Bug 47135 - Implement ApplicationCacheHost::stopLoadingInFrame(Frame*) for Chromium
Summary: Implement ApplicationCacheHost::stopLoadingInFrame(Frame*) for Chromium
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Michael Nordman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-04 17:26 PDT by Hin-Chung Lam
Modified: 2011-03-15 16:15 PDT (History)
1 user (show)

See Also:

Attachments
cleanup (3.42 KB, patch)
2011-03-01 18:55 PST, Michael Nordman 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Hin-Chung Lam 2010-10-04 17:26:20 PDT 
WebKit r69041 added this new method. Since we have a separate implementation of the file we need to implement it correctly.
Comment 1 Michael Nordman 2010-10-05 13:52:35 PDT 
I see, we just need an empty impl of the new method...

void ApplicatinCacheHost::stopLoadingInFrame(Frame*)
{
  // N/A to the chromium port which doesn't use webcore's loader.
}

So the build fix is the real fix (modulo the comment).
Comment 2 Michael Nordman 2011-03-01 18:55:21 PST 
Created attachment 84355 [details]
cleanup
Comment 3 Michael Nordman 2011-03-02 12:06:02 PST 
Comment on attachment 84355 [details]
cleanup

nm... i'll just commit these unreviewed
Comment 4 Michael Nordman 2011-03-15 16:15:23 PDT 
the code comment has been changed