RESOLVED FIXED 47130
[chromium] Get the link from a plugin when creating a context menu 
https://bugs.webkit.org/show_bug.cgi?id=47130
Summary [chromium] Get the link from a plugin when creating a context menu
John Abd-El-Malek
Reported 2010-10-04 16:34:11 PDT
[chromium] Get the link from a plugin when creating a context menu
Attachments
Patch (2.79 KB, patch)
2010-10-04 16:36 PDT, John Abd-El-Malek 		no flags
DetailsFormatted DiffDiff
Patch (4.76 KB, patch)
2010-10-05 13:06 PDT, John Abd-El-Malek 		fishd: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
John Abd-El-Malek
Comment 1 2010-10-04 16:36:12 PDT
Created attachment 69714 [details] Patch
Darin Fisher (:fishd, Google)
Comment 2 2010-10-04 20:28:12 PDT
Comment on attachment 69714 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=69714&action=review > WebKit/chromium/public/WebPlugin.h:104 > + virtual WebURL absoluteURL(const WebPoint& position) const { return WebURL(); } hmm... the name of this method could use some improvements. something like absoluteURLAtPosition would be better, but even that is fairly awkward and not as self-documenting as it ought to be. maybe using the word "link" would help or even "href"... hmm, I'll think on this.
Darin Fisher (:fishd, Google)
Comment 3 2010-10-04 22:19:31 PDT
Could this API also be used to show a status message when the user hovers over a link? WebPlugin::{href,link}AtPosition
John Abd-El-Malek
Comment 4 2010-10-05 12:59:34 PDT
(In reply to comment #3) > Could this API also be used to show a status message when the user hovers over a link? ah yes, good suggestion. > > WebPlugin::{href,link}AtPosition linkAtPosition sounds good
John Abd-El-Malek
Comment 5 2010-10-05 13:06:10 PDT
Created attachment 69830 [details] Patch
John Abd-El-Malek
Comment 6 2010-10-05 15:46:06 PDT
Committed r69154: <http://trac.webkit.org/changeset/69154>
Note You need to log in before you can comment on or make changes to this bug.