Bug 47127 - Added event onwebkitspeechchange and invoke on new speech input results.
Summary: Added event onwebkitspeechchange and invoke on new speech input results.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 39485
  Show dependency treegraph
 
Reported: 2010-10-04 15:59 PDT by Satish Sampath
Modified: 2010-10-05 10:10 PDT (History)
5 users (show)

See Also:


Attachments
Patch (8.24 KB, patch)
2010-10-04 16:14 PDT, Satish Sampath
no flags Details | Formatted Diff | Diff
Patch (8.25 KB, patch)
2010-10-05 02:43 PDT, Satish Sampath
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Satish Sampath 2010-10-04 15:59:25 PDT
This patch adds the event 'webkitspeechchange' to the input element and attribute 'onwebkitspeechchange' to the input element IDL. Until now when receiving new speech input results, the input element's 'onchange' event handler was invoked. Instead of that we are now invoking the 'onwebkitspeechchange' handler. Also updated the relevant layout tests.
Comment 1 Satish Sampath 2010-10-04 16:14:43 PDT
Created attachment 69711 [details]
Patch

Adding Kent Tamura as an additional reviewer as he is familiar with the input element.
Comment 2 Jeremy Orlow 2010-10-04 16:26:52 PDT
Comment on attachment 69711 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=69711&action=review

r=me assuming you fix the nits

> WebCore/html/HTMLInputElement.cpp:1214
> +    } else if (attr->name() == onwebkitspeechchangeAttr) {

no {}s

> WebCore/html/HTMLInputElement.idl:104
> +#if !defined(LANGUAGE_OBJECTIVE_C) || !LANGUAGE_OBJECTIVE_C

Why do this?
Comment 3 Kent Tamura 2010-10-05 02:23:05 PDT
(In reply to comment #2)

> > WebCore/html/HTMLInputElement.idl:104
> > +#if !defined(LANGUAGE_OBJECTIVE_C) || !LANGUAGE_OBJECTIVE_C
> 
> Why do this?

I have the same question.  I have no idea of reasons to omit it for Objective-C.
Comment 4 Satish Sampath 2010-10-05 02:38:09 PDT
(In reply to comment #3)
> (In reply to comment #2)
> 
> > > WebCore/html/HTMLInputElement.idl:104
> > > +#if !defined(LANGUAGE_OBJECTIVE_C) || !LANGUAGE_OBJECTIVE_C
> > 
> > Why do this?
> 
> I have the same question.  I have no idea of reasons to omit it for Objective-C.

I don't know the reason, but I saw two prominent IDLs do it in this fashion (http://trac.webkit.org/browser/trunk/WebCore/dom/Element.idl#L139 and similarly in WebCore/dom/Document.idl) and hence followed that. But I also notice many other IDLs not use this ifdef guard, so I'll remove it now and if required in future will add.
Comment 5 Satish Sampath 2010-10-05 02:43:11 PDT
Created attachment 69765 [details]
Patch

Patch with comments addressed, will submit.
Comment 6 WebKit Review Bot 2010-10-05 03:14:27 PDT
Comment on attachment 69765 [details]
Patch

Rejecting patch 69765 from review queue.

satish@chromium.org does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/common/config/committers.py.

- If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have reviewer rights please correct the error in WebKitTools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your reviewer rights.
Comment 7 WebKit Commit Bot 2010-10-05 03:44:54 PDT
Comment on attachment 69765 [details]
Patch

Clearing flags on attachment: 69765

Committed r69100: <http://trac.webkit.org/changeset/69100>
Comment 8 WebKit Commit Bot 2010-10-05 03:44:59 PDT
All reviewed patches have been landed.  Closing bug.
Comment 9 Eric Seidel (no email) 2010-10-05 10:03:27 PDT
This is Android specific it seems. What spec covers this?
Comment 10 Jeremy Orlow 2010-10-05 10:08:11 PDT
(In reply to comment #9)
> This is Android specific it seems. What spec covers this?

Satish works on Chromium (he has a chromium.org address :-)

The W3C Speech XG is where the standard development is happening.
Comment 11 Jeremy Orlow 2010-10-05 10:10:38 PDT
(In reply to comment #10)
> (In reply to comment #9)
> > This is Android specific it seems. What spec covers this?
> 
> Satish works on Chromium (he has a chromium.org address :-)
> 
> The W3C Speech XG is where the standard development is happening.

If you're interested in this, you should look at the parent (blocks) bug...there's a lot of information in there.
Comment 12 Jeremy Orlow 2010-10-05 10:10:50 PDT
(In reply to comment #10)
> (In reply to comment #9)
> > This is Android specific it seems. What spec covers this?
> 
> Satish works on Chromium (he has a chromium.org address :-)
> 
> The W3C Speech XG is where the standard development is happening.

If you're interested in this, you should look at the parent (blocks) bug...there's a lot of information in there.