RESOLVED FIXED 47114
Add ENABLE(ACCELERATED_2D_CANVAS) guard for m_uploadTexture 
https://bugs.webkit.org/show_bug.cgi?id=47114
Summary Add ENABLE(ACCELERATED_2D_CANVAS) guard for m_uploadTexture
Kwang Yul Seo
Reported 2010-10-04 14:32:36 PDT
PlatformContextSkia's m_uploadTexture is used only in code guarded with ENABLE(ACCELERATED_2D_CANVAS).
Attachments
Patch (1.20 KB, patch)
2010-10-04 14:33 PDT, Kwang Yul Seo 		kling: review-
DetailsFormatted DiffDiff
Patch (1.25 KB, patch)
2010-10-07 12:43 PDT, Kwang Yul Seo 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kwang Yul Seo
Comment 1 2010-10-04 14:33:32 PDT
Created attachment 69683 [details] Patch
Andreas Kling
Comment 2 2010-10-06 23:45:11 PDT
Comment on attachment 69683 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=69683&action=review > WebCore/platform/graphics/skia/PlatformContextSkia.h:236 > +#if ENABLE(ACCELERATED_2D_CANVAS) > mutable RefPtr<Texture> m_uploadTexture; > +#endif There's an ENABLE(ACCELERATED_2D_CANVAS) guard just above, put both variables in there instead.
Kwang Yul Seo
Comment 3 2010-10-07 12:43:22 PDT
Created attachment 70131 [details] Patch Move m_uploadTexture to the ENABLE(ACCELERATED_2D_CANVAS) guard above.
Andreas Kling
Comment 4 2010-10-09 10:43:16 PDT
Comment on attachment 70131 [details] Patch LGTM.
WebKit Commit Bot
Comment 5 2010-10-09 11:11:26 PDT
Comment on attachment 70131 [details] Patch Clearing flags on attachment: 70131 Committed r69450: <http://trac.webkit.org/changeset/69450>
WebKit Commit Bot
Comment 6 2010-10-09 11:11:34 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.