RESOLVED FIXED 47113
Move SharedGraphicsContext3D from ChromeClient to Page 
https://bugs.webkit.org/show_bug.cgi?id=47113
Summary Move SharedGraphicsContext3D from ChromeClient to Page
Chris Marrin
Reported 2010-10-04 14:12:22 PDT
In talking to James Robinson, we've agreed that SharedGraphicsContext3D doesn't need to be in ChromeClient. Page has the same lifetime and there are no platform dependencies in this class.
Attachments
Patch (7.97 KB, patch)
2010-10-04 14:30 PDT, Chris Marrin 		no flags
DetailsFormatted DiffDiff
Patch (9.45 KB, patch)
2010-10-04 15:07 PDT, Chris Marrin 		jamesr: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Marrin
Comment 1 2010-10-04 14:30:45 PDT
Created attachment 69681 [details] Patch
Simon Fraser (smfr)
Comment 2 2010-10-04 14:39:03 PDT
Comment on attachment 69681 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=69681&action=review > WebCore/page/Page.cpp:783 > + if (!context) > + return 0; > + m_sharedGraphicsContext3D = SharedGraphicsContext3D::create(context.release()); > + } I think the GraphicsContext3D::create() stuff should be hidden inside of static bool SharedGraphicsContext3D::canCreateContext() or something, or maybe SharedGraphicsContext3D::create() should just return 0 if the context can't be created.
Chris Marrin
Comment 3 2010-10-04 15:07:41 PDT
Created attachment 69695 [details] Patch
James Robinson
Comment 4 2010-10-04 17:03:42 PDT
Comment on attachment 69695 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=69695&action=review Looks fine to me. > WebCore/page/Page.cpp:69 > +#if ENABLE(ACCELERATED_2D_CANVAS) > +#include "SharedGraphicsContext3D.h" > +#endif Normally conditionally included headers are put after the main list of headers, not in the middle.
Chris Marrin
Comment 5 2010-10-04 17:10:23 PDT
Landed in http://trac.webkit.org/changeset/69053
Note You need to log in before you can comment on or make changes to this bug.