RESOLVED FIXED Bug 47112
Convert addOverhangingFloats and addIntrudingFloats to be block-flow-aware. 
https://bugs.webkit.org/show_bug.cgi?id=47112
Summary Convert addOverhangingFloats and addIntrudingFloats to be block-flow-aware.
Dave Hyatt
Reported 2010-10-04 14:03:41 PDT
Convert addOverhangingFloats and addIntrudingFloats to be block-flow-aware. Also clean up how floats are placed to use a bit instead of the magic -1 value on top().
Attachments
Patch (14.91 KB, patch)
2010-10-04 14:49 PDT, Dave Hyatt 		mitz: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dave Hyatt
Comment 1 2010-10-04 14:49:09 PDT
Created attachment 69688 [details] Patch
mitz
Comment 2 2010-10-04 15:08:19 PDT
Comment on attachment 69688 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=69688&action=review > WebCore/rendering/RenderBlock.h:393 > int left() const { return m_frameRect.x(); } > int right() const { return m_frameRect.right(); } > int top() const { return m_frameRect.y(); } Should these accessors ASSERT(m_isPlaced)?
Dave Hyatt
Comment 3 2010-10-04 23:14:22 PDT
Fixed in r69082. The asserts caught some badness, so there's some additional code.
WebKit Review Bot
Comment 4 2010-10-04 23:24:54 PDT
http://trac.webkit.org/changeset/69082 might have broken Qt Linux Release minimal, Qt Linux ARMv5 Release, and Qt Linux ARMv7 Release
Note You need to log in before you can comment on or make changes to this bug.