WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
47100
Convert clearFloats() to be block-flow-aware.
https://bugs.webkit.org/show_bug.cgi?id=47100
Summary
Convert clearFloats() to be block-flow-aware.
Dave Hyatt
Reported
2010-10-04 11:40:26 PDT
Convert clearFloats() to be block-flow-aware. Helpers that it calls have not been patched though.
Attachments
Patch
(6.84 KB, patch)
2010-10-04 11:41 PDT
,
Dave Hyatt
no flags
Details
Formatted Diff
Diff
Patch
(6.85 KB, patch)
2010-10-04 11:47 PDT
,
Dave Hyatt
no flags
Details
Formatted Diff
Diff
I am fail.
(6.86 KB, patch)
2010-10-04 11:56 PDT
,
Dave Hyatt
mitz: review+
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Dave Hyatt
Comment 1
2010-10-04 11:41:26 PDT
Created
attachment 69652
[details]
Patch
mitz
Comment 2
2010-10-04 11:44:25 PDT
Comment on
attachment 69652
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=69652&action=review
> WebCore/rendering/RenderBlock.cpp:3687 > + changeLogicalTop = max(changeLogicalTop, logicalBottom);
Typo?
Dave Hyatt
Comment 3
2010-10-04 11:47:48 PDT
Created
attachment 69655
[details]
Patch
Dave Hyatt
Comment 4
2010-10-04 11:56:48 PDT
Created
attachment 69659
[details]
I am fail.
Dave Hyatt
Comment 5
2010-10-04 12:05:41 PDT
Fixed in
r69025
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug