Bug 47100 - Convert clearFloats() to be block-flow-aware.
Summary: Convert clearFloats() to be block-flow-aware.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Dave Hyatt
URL:
Keywords:
Depends on:
Blocks: 46123
  Show dependency tree / graph
 
Reported: 2010-10-04 11:40 PDT by Dave Hyatt
Modified: 2010-10-04 12:05 PDT (History)
0 users

See Also:

Attachments
Patch (6.84 KB, patch)
2010-10-04 11:41 PDT, Dave Hyatt 		no flags Details | Formatted Diff | Diff
Patch (6.85 KB, patch)
2010-10-04 11:47 PDT, Dave Hyatt 		no flags Details | Formatted Diff | Diff
I am fail. (6.86 KB, patch)
2010-10-04 11:56 PDT, Dave Hyatt 		mitz: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Hyatt 2010-10-04 11:40:26 PDT 
Convert clearFloats() to be block-flow-aware.  Helpers that it calls have not been patched though.
Comment 1 Dave Hyatt 2010-10-04 11:41:26 PDT 
Created attachment 69652 [details]
Patch
Comment 2 mitz 2010-10-04 11:44:25 PDT 
Comment on attachment 69652 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=69652&action=review

> WebCore/rendering/RenderBlock.cpp:3687
> +                    changeLogicalTop = max(changeLogicalTop, logicalBottom);

Typo?
Comment 3 Dave Hyatt 2010-10-04 11:47:48 PDT 
Created attachment 69655 [details]
Patch
Comment 4 Dave Hyatt 2010-10-04 11:56:48 PDT 
Created attachment 69659 [details]
I am fail.
Comment 5 Dave Hyatt 2010-10-04 12:05:41 PDT 
Fixed in r69025.