Bug 47088 – Reduce some code duplication

• Status: RESOLVED
• Resolution: WONTFIX
• Component: Platform

The attached patch reduces some code duplication to make the code a little more readable (and reduce the LOC by ~1500). This does not introduce any changes to the functionality, so no new layout tests is necessary.

Created attachment 69636 [details]
Patch

[WebKit Review Bot]

Attachment 69636 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebCore/platform/LocalizedStrings.cpp:42:  Tab found; better to use spaces  [whitespace/tab] [1]
WebCore/platform/gtk/LocalizedStringsGtk.cpp:57:  Tab found; better to use spaces  [whitespace/tab] [1]
Total errors found: 2 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Review Bot]

Attachment 69636 [details] did not build on gtk:
Build output: http://queues.webkit.org/results/4241032

Created attachment 69641 [details]
Revised patch to pass the tests

Oops!

[David Levin]

This patch is all above putting in macros in place of very simple and short C code.

Putting in macro's so that one has another level of indirection in determining what the code does, doesn't seem like a move in a good direction to me. This makes it less readable to me.

[Adam Barth]

Comment on attachment 69641 [details]
Revised patch to pass the tests

I agree with Dave Levin.