Bug 47085 – Web Inspector: set XHR breakpoint from resource panel

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Pavel Podivilov]

Web Inspector: set XHR breakpoint from resource panel

Add "Set Breakpoint" item to XHR resource context menu.

[Pavel Podivilov]

Created attachment 69631 [details]
Patch.

[Alexander Pavlov (apavlov)]

Comment on attachment 69631 [details]
Patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=69631&action=review

> WebCore/inspector/front-end/ResourcesPanel.js:1255
> +        var resource = null;

Seems like there's no need to initialize this explicitly

> WebCore/inspector/front-end/ResourcesPanel.js:1268
> +        if (resource && resource.category.name === "xhr") {

(... && resource.category === WebInspector.resourceCategories.xhr)
looks cleaner

[Pavel Podivilov]

Created attachment 69787 [details]
Patch.

Comments addressed.

[Yury Semikhatsky]

Comment on attachment 69787 [details]
Patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=69787&action=review

> WebCore/inspector/front-end/ResourcesPanel.js:1271
> +            contextMenu.appendItem(WebInspector.UIString("Set Breakpoint"), WebInspector.breakpointManager.createXHRBreakpoint.bind(WebInspector.breakpointManager, resource.url));

We may want to be more specific about the nature of the breakpoint to set.

[Pavel Podivilov]

Committed r69180: <http://trac.webkit.org/changeset/69180>

[Pavel Podivilov]

(In reply to comment #4)
> (From update of attachment 69787 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=69787&action=review
> 
> > WebCore/inspector/front-end/ResourcesPanel.js:1271
> > +            contextMenu.appendItem(WebInspector.UIString("Set Breakpoint"), WebInspector.breakpointManager.createXHRBreakpoint.bind(WebInspector.breakpointManager, resource.url));
> 
> We may want to be more specific about the nature of the breakpoint to set.

I've accidentally committed it with "Set Breakpoint". Let me fix the wording in a separate patch.