Bug 47081 - Web Inspector: add total bar to the network panel.
Summary: Web Inspector: add total bar to the network panel.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-04 06:12 PDT by Pavel Feldman
Modified: 2010-10-04 06:43 PDT (History)
10 users (show)

See Also:


Attachments
[PATCH] Proposed change. (22.75 KB, patch)
2010-10-04 06:14 PDT, Pavel Feldman
yurys: review+
Details | Formatted Diff | Diff
[IMAGE] Looks with the patch applied. (92.52 KB, image/png)
2010-10-04 06:17 PDT, Pavel Feldman
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2010-10-04 06:12:26 PDT
Few drive-by fixes.
Comment 1 Pavel Feldman 2010-10-04 06:14:35 PDT
Created attachment 69624 [details]
[PATCH] Proposed change.
Comment 2 Pavel Feldman 2010-10-04 06:17:30 PDT
Created attachment 69626 [details]
[IMAGE] Looks with the patch applied.
Comment 3 Yury Semikhatsky 2010-10-04 06:33:59 PDT
Comment on attachment 69624 [details]
[PATCH] Proposed change.

View in context: https://bugs.webkit.org/attachment.cgi?id=69624&action=review

> WebCore/inspector/front-end/DataGrid.js:549
> +            if (a._dataGridNode._data.summaryRow)

Would be nice to have this summary bar extracted into a separate entity that can be easily distinguished from the regular nodes.
Comment 4 Pavel Feldman 2010-10-04 06:43:01 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ...
        M       WebCore/ChangeLog
        M       WebCore/English.lproj/localizedStrings.js
        M       WebCore/inspector/front-end/ConsoleView.js
        M       WebCore/inspector/front-end/DataGrid.js
        M       WebCore/inspector/front-end/NetworkPanel.js
        M       WebCore/inspector/front-end/ResourcesPanel.js
        M       WebCore/inspector/front-end/inspector.css
        M       WebCore/inspector/front-end/networkPanel.css
Committed r69010