Bug 47080 - Web Inspector: [Chromium][Extension API] provide tab id of inspected tab in extension API
Summary: Web Inspector: [Chromium][Extension API] provide tab id of inspected tab in e...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Andrey Kosyakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-04 05:40 PDT by Andrey Kosyakov
Modified: 2010-10-06 01:13 PDT (History)
4 users (show)

See Also:


Attachments
patch (3.22 KB, patch)
2010-10-04 05:48 PDT, Andrey Kosyakov
yurys: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Kosyakov 2010-10-04 05:40:58 PDT
Since we now expose native browser extension API to WebInspector extensions, it would be useful for the extensions to know tab id of inspected page -- this way, native extension mechanisms may be used to inject CSS and scripts.
It is suggested to expose inspected page's tab id as webInspector.inspectedWindow.tabId property.
Comment 1 Andrey Kosyakov 2010-10-04 05:48:48 PDT
Created attachment 69621 [details]
patch
Comment 2 WebKit Review Bot 2010-10-04 10:42:46 PDT
Comment on attachment 69621 [details]
patch

Rejecting patch 69621 from commit-queue.

caseq@chromium.org does not have committer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/common/config/committers.py.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in WebKitTools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.
Comment 3 Andrey Kosyakov 2010-10-06 01:13:39 PDT
Committed manually r69098: http://trac.webkit.org/changeset/69098