Bug 47066 – Add ability to set the CacheModel in Webkit2

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Sam Weinig]

Add ability to set the CacheModel in Webkit2

[Sam Weinig]

Created attachment 69596 [details]
Patch

[WebKit Review Bot]

Attachment 69596 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit2/WebProcess/win/WebProcessWin.cpp:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebKit2/WebProcess/qt/WebProcessQt.cpp:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebKit2/WebProcess/WebProcess.cpp:228:  WebProcess::pages_begin is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebKit2/WebProcess/WebProcess.cpp:233:  WebProcess::pages_end is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebKit2/Shared/WebPreferencesStore.h:32:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
WebKit2/WebProcess/WebProcess.h:54:  pages_const_iterator is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebKit2/WebProcess/WebProcess.h:68:  pages_begin is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebKit2/WebProcess/WebProcess.h:69:  pages_end is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 8 in 24 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Sam Weinig]

Comment on attachment 69596 [details]
Patch

I am going to go in another direction with this.

[Sam Weinig]

Created attachment 69597 [details]
Patch

[WebKit Review Bot]

Attachment 69597 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit2/WebProcess/win/WebProcessWin.cpp:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebKit2/WebProcess/qt/WebProcessQt.cpp:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 2 in 18 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Anders Carlsson]

Comment on attachment 69597 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=69597&action=review

I don't see you adding WebProcessQt to the relevant build system, please do that too.

> WebKit2/WebProcess/mac/WebProcessMac.mm:233
> +    printf("Page Cache: %d\n", pageCache()->capacity());

Please don't check this in.

[Sam Weinig]

Landed in http://trac.webkit.org/changeset/69020.