Bug 47021 - Patch the floatBottom function and its friends.
Summary: Patch the floatBottom function and its friends.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Dave Hyatt
URL:
Keywords:
Depends on:
Blocks: 46643
  Show dependency tree / graph
 
Reported: 2010-10-01 15:15 PDT by Dave Hyatt
Modified: 2010-10-01 17:16 PDT (History)
1 user (show)

See Also:

Attachments
Patch (17.74 KB, patch)
2010-10-01 15:17 PDT, Dave Hyatt 		mitz: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Hyatt 2010-10-01 15:15:19 PDT 
Patch the floatBottom function and its friends.  Rename them and consolidate them to be block-flow-aware.
Comment 1 Dave Hyatt 2010-10-01 15:17:03 PDT 
Created attachment 69526 [details]
Patch
Comment 2 mitz 2010-10-01 15:51:34 PDT 
Comment on attachment 69526 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=69526&action=review

> WebCore/rendering/RenderBlock.cpp:3296
> -int
> -RenderBlock::floatBottom() const
> +int RenderBlock::lowestFloatLogicalBottom(FloatingObject::Type floatType) const

Finally!

> WebCore/rendering/RenderBlock.cpp:3304
> +        if (r->type() & floatType)

Kind of ugly. I’d like at least to see a comment about the definition of the FloatingObject::Type enum saying that it’s a bitfield.
Comment 3 mitz 2010-10-01 15:52:02 PDT 
(In reply to comment #2)
> I’d like at least to see a comment about the definition of the FloatingObject::Type enum saying that it’s a bitfield.

s/about/above/
Comment 4 Dave Hyatt 2010-10-01 17:16:34 PDT 
Fixed in r68957.