Bug 47015 - Change FloatingObject to store its dimensions as a rect.
Summary: Change FloatingObject to store its dimensions as a rect.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Dave Hyatt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-01 13:57 PDT by Dave Hyatt
Modified: 2010-10-01 14:25 PDT (History)
1 user (show)

See Also:

Attachments
Patch (27.50 KB, patch)
2010-10-01 13:58 PDT, Dave Hyatt 		mitz: review+
Details | Formatted Diff | Diff
Fix this crappy ancient code to pass the style checks (27.90 KB, patch)
2010-10-01 14:04 PDT, Dave Hyatt 		sam: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Hyatt 2010-10-01 13:57:17 PDT 
Change FloatingObject to store its dimensions as a rect.  This will make it easier for logical access for block-flow later on if top/bottom is no different from left/width.  This change also simplifies calling code a bit in places.
Comment 1 Dave Hyatt 2010-10-01 13:58:19 PDT 
Created attachment 69513 [details]
Patch
Comment 2 WebKit Review Bot 2010-10-01 14:01:41 PDT 
Attachment 69513 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebCore/rendering/RenderBlock.cpp:3224:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
WebCore/rendering/RenderBlock.cpp:3228:  Extra space after ( in if  [whitespace/parens] [5]
WebCore/rendering/RenderBlock.cpp:3228:  Extra space before ) in if  [whitespace/parens] [5]
WebCore/rendering/RenderBlock.cpp:3228:  More than one command on the same line in if  [whitespace/parens] [4]
WebCore/rendering/RenderBlock.cpp:3253:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
WebCore/rendering/RenderBlock.cpp:3257:  Extra space after ( in if  [whitespace/parens] [5]
WebCore/rendering/RenderBlock.cpp:3257:  Extra space before ) in if  [whitespace/parens] [5]
WebCore/rendering/RenderBlock.cpp:3257:  More than one command on the same line in if  [whitespace/parens] [4]
Total errors found: 8 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Dave Hyatt 2010-10-01 14:04:31 PDT 
Created attachment 69514 [details]
Fix this crappy ancient code to pass the style checks
Comment 4 Sam Weinig 2010-10-01 14:21:42 PDT 
Comment on attachment 69514 [details]
Fix this crappy ancient code to pass the style checks

Nice.
Comment 5 Dave Hyatt 2010-10-01 14:25:49 PDT 
Fixed in r68926.