RESOLVED FIXED 47015
Change FloatingObject to store its dimensions as a rect. 
https://bugs.webkit.org/show_bug.cgi?id=47015
Summary Change FloatingObject to store its dimensions as a rect.
Dave Hyatt
Reported 2010-10-01 13:57:17 PDT
Change FloatingObject to store its dimensions as a rect. This will make it easier for logical access for block-flow later on if top/bottom is no different from left/width. This change also simplifies calling code a bit in places.
Attachments
Patch (27.50 KB, patch)
2010-10-01 13:58 PDT, Dave Hyatt 		mitz: review+
DetailsFormatted DiffDiff
Fix this crappy ancient code to pass the style checks (27.90 KB, patch)
2010-10-01 14:04 PDT, Dave Hyatt 		sam: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dave Hyatt
Comment 1 2010-10-01 13:58:19 PDT
Created attachment 69513 [details] Patch
WebKit Review Bot
Comment 2 2010-10-01 14:01:41 PDT
Attachment 69513 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebCore/rendering/RenderBlock.cpp:3224: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] WebCore/rendering/RenderBlock.cpp:3228: Extra space after ( in if [whitespace/parens] [5] WebCore/rendering/RenderBlock.cpp:3228: Extra space before ) in if [whitespace/parens] [5] WebCore/rendering/RenderBlock.cpp:3228: More than one command on the same line in if [whitespace/parens] [4] WebCore/rendering/RenderBlock.cpp:3253: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] WebCore/rendering/RenderBlock.cpp:3257: Extra space after ( in if [whitespace/parens] [5] WebCore/rendering/RenderBlock.cpp:3257: Extra space before ) in if [whitespace/parens] [5] WebCore/rendering/RenderBlock.cpp:3257: More than one command on the same line in if [whitespace/parens] [4] Total errors found: 8 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Dave Hyatt
Comment 3 2010-10-01 14:04:31 PDT
Created attachment 69514 [details] Fix this crappy ancient code to pass the style checks
Sam Weinig
Comment 4 2010-10-01 14:21:42 PDT
Comment on attachment 69514 [details] Fix this crappy ancient code to pass the style checks Nice.
Dave Hyatt
Comment 5 2010-10-01 14:25:49 PDT
Fixed in r68926.
Note You need to log in before you can comment on or make changes to this bug.