Bug 47011 - Add AudioUtilities files
Summary: Add AudioUtilities files
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-01 13:36 PDT by Chris Rogers
Modified: 2010-10-04 23:22 PDT (History)
8 users (show)

See Also:

Attachments
Patch (5.78 KB, patch)
2010-10-01 14:05 PDT, Chris Rogers 		no flags Details | Formatted Diff | Diff
Patch (5.36 KB, patch)
2010-10-04 14:32 PDT, Chris Rogers 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Rogers 2010-10-01 13:36:44 PDT 
Add AudioUtilities files
Comment 1 Chris Rogers 2010-10-01 14:05:58 PDT 
Created attachment 69515 [details]
Patch
Comment 2 chris fleizach 2010-10-04 12:36:33 PDT 
Comment on attachment 69515 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=69515&action=review

your copyright headers don't match

http://trac.webkit.org/browser/trunk/WebKit/LICENSE

> WebCore/platform/audio/AudioUtilities.h:41
> +// discreteTimeConstantForSampleRate() will return the discrete time-constant for the specific sampleRate.

try to wrap at 80 characters for these lines so they're not too long
Comment 3 Chris Rogers 2010-10-04 14:32:46 PDT 
Created attachment 69682 [details]
Patch
Comment 4 Chris Rogers 2010-10-04 14:34:35 PDT 
Hi Chris, I've updated the copyright notice to the standard one we're told to use for Google contributed code and have addressed your other comment.
Comment 5 Kenneth Russell 2010-10-04 15:10:35 PDT 
Comment on attachment 69682 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=69682&action=review

Looks fine overall. One small comment; up to you whether to make this change IMO.

> WebCore/platform/audio/AudioUtilities.cpp:37
> +    return pow(10.0, 0.05 * decibels);

Strictly, this .0 and the others throughout this file are not necessary according to WebKit style ("Floating point literals" on http://webkit.org/coding/coding-style.html ).
Comment 6 WebKit Commit Bot 2010-10-04 23:22:17 PDT 
Comment on attachment 69682 [details]
Patch

Clearing flags on attachment: 69682

Committed r69083: <http://trac.webkit.org/changeset/69083>
Comment 7 WebKit Commit Bot 2010-10-04 23:22:22 PDT 
All reviewed patches have been landed.  Closing bug.