Bug 47011 – Add AudioUtilities files

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Chris Rogers]

Add AudioUtilities files

[Chris Rogers]

Created attachment 69515 [details]
Patch

[chris fleizach]

Comment on attachment 69515 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=69515&action=review

your copyright headers don't match

http://trac.webkit.org/browser/trunk/WebKit/LICENSE

> WebCore/platform/audio/AudioUtilities.h:41
> +// discreteTimeConstantForSampleRate() will return the discrete time-constant for the specific sampleRate.

try to wrap at 80 characters for these lines so they're not too long

[Chris Rogers]

Created attachment 69682 [details]
Patch

[Chris Rogers]

Hi Chris, I've updated the copyright notice to the standard one we're told to use for Google contributed code and have addressed your other comment.

[Kenneth Russell]

Comment on attachment 69682 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=69682&action=review

Looks fine overall. One small comment; up to you whether to make this change IMO.

> WebCore/platform/audio/AudioUtilities.cpp:37
> +    return pow(10.0, 0.05 * decibels);

Strictly, this .0 and the others throughout this file are not necessary according to WebKit style ("Floating point literals" on http://webkit.org/coding/coding-style.html ).

[WebKit Commit Bot]

Comment on attachment 69682 [details]
Patch

Clearing flags on attachment: 69682

Committed r69083: <http://trac.webkit.org/changeset/69083>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.