Bug 46992 – Implement NPN_GetValueForURL/NPN_SetValueForURL and stub out PluginController functions

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Anders Carlsson]

Implement NPN_GetValueForURL/NPN_SetValueForURL and stub out PluginController functions

[Anders Carlsson]

Created attachment 69477 [details]
Patch

[WebKit Review Bot]

Attachment 69477 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit2/WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:698:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
WebKit2/WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:726:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
Total errors found: 2 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Anders Carlsson]

<rdar://problem/8502700>

Comment on attachment 69477 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=69477&action=review

> WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.h:80
> +    String proxiesForURL(const String& urlString);
> +    String cookiesForURL(const String& urlString);

No need to name the argument in these two.

> WebKit2/WebProcess/Plugins/PluginController.h:96
> +    virtual String proxiesForURL(const String& urlString) = 0;
> +
> +    // Returns the cookies for the given URL or null on failure.
> +    virtual String cookiesForURL(const String& urlString) = 0;
> +

No need to name the arguments in these two.

> WebKit2/WebProcess/Plugins/PluginView.h:131
> +    virtual String proxiesForURL(const String& urlString);
> +    virtual String cookiesForURL(const String& urlString);

No need to name the arguments here.

[Anders Carlsson]

Committed r68898: <http://trac.webkit.org/changeset/68898>