Bug 46988 – REGRESSION (r68887): Web Inspector: inspector/extensions*.html are failing on Windows

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Adam Roben (:aroben)]

inspector/extensions*.html are failing on Windows. See the URL for an example of the failures.

[Adam Roben (:aroben)]

<rdar://problem/8502489>

[Adam Roben (:aroben)]

(In reply to bug 45954 comment #8)
> the -api.html suggests that frontend is of an older version (i.e. lacks a method introduced in this patch; I don't think there's a space for any flakiness there). This also does not reproduce locally. 
> Can we clobber the win bots?
> Also, I reckon that build-webkit does not copy inspector front-end files under windows, unless --inspector-frontend is specified or there's a larger change outside of inspector/front-end. If clobbering fixes the tests, I think we need to raise a bug for build to perform build-webkit --inspector-frontend at least on bots (it's cheap).

OK, it sounds like you're saying that the problem is that there are stale front-end JS files in the bots' build directories.

Looking at build-webkit, I can't see how --inspector-frontend actually works.

But I don't think a change to build-webkit is the answer. We want this to work for people who build directly from Visual Studio, too. I think the right way to fix this is to move the copying of these files from WebCore.vcproj (which only runs when a .cpp or .h file changes) to WebCoreGenerated.vcproj (which always runs).

[Adam Roben (:aroben)]

Created attachment 69489 [details]
Copy forwarding headers and Inspector JS files as part of WebCoreGenerated.vcproj

[Adam Roben (:aroben)]

Committed r68905: <http://trac.webkit.org/changeset/68905>