Bug 46979 - [WINCE] Use alphaBlendIfSupported in GraphicsContext
Summary: [WINCE] Use alphaBlendIfSupported in GraphicsContext
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Other
: P2 Normal
Assignee: Patrick R. Gansterer
URL:
Keywords:
Depends on: 46974
Blocks:
  Show dependency treegraph
 
Reported: 2010-10-01 05:29 PDT by Patrick R. Gansterer
Modified: 2010-10-01 06:07 PDT (History)
1 user (show)

See Also:


Attachments
Patch (2.68 KB, patch)
2010-10-01 05:32 PDT, Patrick R. Gansterer
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick R. Gansterer 2010-10-01 05:29:53 PDT
see patch
Comment 1 Patrick R. Gansterer 2010-10-01 05:32:08 PDT
Created attachment 69456 [details]
Patch
Comment 2 Adam Roben (:aroben) 2010-10-01 05:52:29 PDT
Comment on attachment 69456 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=69456&action=review

> WebCore/platform/graphics/wince/GraphicsContextWinCE.cpp:341
> +            if (!alphaBlendIfSupported(m_dc, origRect.x(), origRect.y(), origRect.width(), origRect.height(), hdc, 0, 0, bmpRect.right, bmpRect.bottom, blend))
> +                ASSERT_NOT_REACHED();

Another way to do this without a branch is:

bool success = alphaBlendIfSupported(...);
ASSERT_UNUSED(success, success);
Comment 3 Patrick R. Gansterer 2010-10-01 06:06:48 PDT
Comment on attachment 69456 [details]
Patch

Clearing flags on attachment: 69456

Manually committed r68882: <http://trac.webkit.org/changeset/68882>
Comment 4 Patrick R. Gansterer 2010-10-01 06:07:26 PDT
All reviewed patches have been landed.  Closing bug.