Bug 46964 - Add SVGTextMetrics/SVGTextFragment/SVGTextChunk primitives used by the new layout engine
Summary: Add SVGTextMetrics/SVGTextFragment/SVGTextChunk primitives used by the new la...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nikolas Zimmermann
URL:
Keywords:
Depends on:
Blocks: 45532
  Show dependency treegraph
 
Reported: 2010-10-01 00:41 PDT by Nikolas Zimmermann
Modified: 2010-10-01 02:15 PDT (History)
8 users (show)

See Also:


Attachments
Patch (27.04 KB, patch)
2010-10-01 00:49 PDT, Nikolas Zimmermann
no flags Details | Formatted Diff | Diff
Patch v2 (26.25 KB, patch)
2010-10-01 01:03 PDT, Nikolas Zimmermann
no flags Details | Formatted Diff | Diff
Patch v3 (28.80 KB, patch)
2010-10-01 01:32 PDT, Nikolas Zimmermann
krit: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nikolas Zimmermann 2010-10-01 00:41:37 PDT
SVGTextMetrics encapsulates measuring text.
SVGTextFragment represents a portion of text that can be rendered/measured in one shot.
(RenderSVGInlineTextBox contains N text boxes, which in turn can contain M fragments)
SVGTextChunk describes a set of fragments, which have to be treated as "one single text" in terms of measuring (used to process text-anchor & textLength corrections on line-layouted text, not for path layouts).
Comment 1 Nikolas Zimmermann 2010-10-01 00:49:44 PDT
Created attachment 69431 [details]
Patch
Comment 2 WebKit Review Bot 2010-10-01 00:56:46 PDT
Attachment 69431 [details] did not build on gtk:
Build output: http://queues.webkit.org/results/4165037
Comment 3 Eric Seidel (no email) 2010-10-01 00:57:41 PDT
Attachment 69431 [details] did not build on mac:
Build output: http://queues.webkit.org/results/4143037
Comment 4 Early Warning System Bot 2010-10-01 00:58:31 PDT
Attachment 69431 [details] did not build on qt:
Build output: http://queues.webkit.org/results/4193037
Comment 5 WebKit Review Bot 2010-10-01 01:01:28 PDT
Attachment 69431 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/4192039
Comment 6 Nikolas Zimmermann 2010-10-01 01:03:36 PDT
Created attachment 69432 [details]
Patch v2

Renamed SVGTextChunk to SVGTextChunkNew, to avoid clashes with the SVGTextChunk class that still lives in SVGTextChunkLayoutInfo.h (which will be removed alltogether, once the new engine lands);
Comment 7 WebKit Review Bot 2010-10-01 01:09:07 PDT
Attachment 69432 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebCore/rendering/svg/SVGTextChunk.cpp:47:  Tab found; better to use spaces  [whitespace/tab] [1]
Total errors found: 1 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 8 Eric Seidel (no email) 2010-10-01 01:11:07 PDT
Attachment 69432 [details] did not build on mac:
Build output: http://queues.webkit.org/results/4170047
Comment 9 Nikolas Zimmermann 2010-10-01 01:32:04 PDT
Created attachment 69434 [details]
Patch v3

Fix style issue, mac build problem and write a much more explicit ChangeLog, as requested by Dirk.
Comment 10 Dirk Schulze 2010-10-01 02:07:58 PDT
Comment on attachment 69434 [details]
Patch v3

LGTM. We already discussed some changes on IRC (can be seen by comparing the different patches). Niko has the next patch ready, that moves some files, so that we can fix the FIXMEs.  r=me
Comment 11 Nikolas Zimmermann 2010-10-01 02:14:14 PDT
Landed in r68873.