Bug 46964 – Add SVGTextMetrics/SVGTextFragment/SVGTextChunk primitives used by the new layout engine

• Status: RESOLVED
• Resolution: FIXED
• Component: SVG

[Nikolas Zimmermann]

SVGTextMetrics encapsulates measuring text.
SVGTextFragment represents a portion of text that can be rendered/measured in one shot.
(RenderSVGInlineTextBox contains N text boxes, which in turn can contain M fragments)
SVGTextChunk describes a set of fragments, which have to be treated as "one single text" in terms of measuring (used to process text-anchor & textLength corrections on line-layouted text, not for path layouts).

[Nikolas Zimmermann]

Created attachment 69431 [details]
Patch

[WebKit Review Bot]

Attachment 69431 [details] did not build on gtk:
Build output: http://queues.webkit.org/results/4165037

[Eric Seidel (no email)]

Attachment 69431 [details] did not build on mac:
Build output: http://queues.webkit.org/results/4143037

[Early Warning System Bot]

Attachment 69431 [details] did not build on qt:
Build output: http://queues.webkit.org/results/4193037

[WebKit Review Bot]

Attachment 69431 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/4192039

[Nikolas Zimmermann]

Created attachment 69432 [details]
Patch v2

Renamed SVGTextChunk to SVGTextChunkNew, to avoid clashes with the SVGTextChunk class that still lives in SVGTextChunkLayoutInfo.h (which will be removed alltogether, once the new engine lands);

[WebKit Review Bot]

Attachment 69432 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebCore/rendering/svg/SVGTextChunk.cpp:47:  Tab found; better to use spaces  [whitespace/tab] [1]
Total errors found: 1 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Eric Seidel (no email)]

Attachment 69432 [details] did not build on mac:
Build output: http://queues.webkit.org/results/4170047

[Nikolas Zimmermann]

Created attachment 69434 [details]
Patch v3

Fix style issue, mac build problem and write a much more explicit ChangeLog, as requested by Dirk.

[Dirk Schulze]

Comment on attachment 69434 [details]
Patch v3

LGTM. We already discussed some changes on IRC (can be seen by comparing the different patches). Niko has the next patch ready, that moves some files, so that we can fix the FIXMEs.  r=me

[Nikolas Zimmermann]

Landed in r68873.