Bug 46963 – Add helper methods to cast between renderers & SVGTextContent/PositioningElement

• Status: RESOLVED
• Resolution: FIXED
• Component: SVG

[Nikolas Zimmermann]

The new text layout engine needs a simple way to cast a inlineTextBox->renderer() to either SVGTextContentElement or SVGTextPositioningElement.
Add static helper methods doing that.

[Nikolas Zimmermann]

Created attachment 69428 [details]
Patch

[Dirk Schulze]

Comment on attachment 69428 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=69428&action=review

The patch itself looks good to me. r=me with the fixes.

> WebCore/svg/SVGTextContentElement.cpp:219
> +SVGTextContentElement* SVGTextContentElement::fromRenderer(RenderObject* renderer)

Another name for 'fromRenderer' is maybe more self-explanatory. Niko suggested elementFromRenderer.

> WebCore/svg/SVGTextContentElement.cpp:238
> +    if (!node->hasTagName(SVGNames::textTag)
> +     && !node->hasTagName(SVGNames::tspanTag)
> +#if ENABLE(SVG_FONTS)
> +     && !node->hasTagName(SVGNames::altGlyphTag)
> +#endif
> +     && !node->hasTagName(SVGNames::trefTag)
> +     && !node->hasTagName(SVGNames::textPathTag))
> +        return 0;

The indention is wrong.

> WebCore/svg/SVGTextPositioningElement.cpp:164
> +    if (!node->hasTagName(SVGNames::textTag)
> +     && !node->hasTagName(SVGNames::tspanTag)
> +#if ENABLE(SVG_FONTS)
> +     && !node->hasTagName(SVGNames::altGlyphTag)
> +#endif
> +     && !node->hasTagName(SVGNames::trefTag))
> +        return 0;

wrong indention.

[Nikolas Zimmermann]

Landed in r68867.