Bug 46947 – texImage2D fails on 16-bit-per-channel images

• Status: RESOLVED
• Resolution: FIXED
• Component: WebGL

[Zhenyao Mo]

Loading a 16-bit-per-channel will fail with an INVALID_VALUE error.

[Zhenyao Mo]

Created attachment 69404 [details]
patch

[Zhenyao Mo]

By the way, the 16-bit images are loading fine in Chromium Win, so adding this test entry should pass on all platforms.

[Zhenyao Mo]

Created attachment 69409 [details]
revised patch

Forgot about also updating the expected.txt file.

[Kenneth Russell]

Comment on attachment 69409 [details]
revised patch

View in context: https://bugs.webkit.org/attachment.cgi?id=69409&action=review

Looks OK. I think we should try to figure out a different structure (like a table) for the large switch statements in GraphicsContext3D::getImageData because they're really getting out of hand. Please consider filing a follow-up bug to rethink the structure there. One minor comment-related comment.

> WebCore/platform/graphics/cg/GraphicsContext3DCG.cpp:131
>          // This path is only accessible for MacOS earlier than 10.6.4.

Is this comment still accurate?

[Zhenyao Mo]

(In reply to comment #4)
> (From update of attachment 69409 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=69409&action=review
> 
> Looks OK. I think we should try to figure out a different structure (like a table) for the large switch statements in GraphicsContext3D::getImageData because they're really getting out of hand. Please consider filing a follow-up bug to rethink the structure there. One minor comment-related comment.
> 
> > WebCore/platform/graphics/cg/GraphicsContext3DCG.cpp:131
> >          // This path is only accessible for MacOS earlier than 10.6.4.
> 
> Is this comment still accurate?

Yes, it still is.  Alpha first formats are not encountered so far on 10.6.4.

I'll leave the comments in.  If you think it's un-necessary to keep them, we can remove them in the follow-up bug.

I added these comments in case in the future such path got removed when a developer only deals with newer CG libs.

[Zhenyao Mo]

Committed r68940: <http://trac.webkit.org/changeset/68940>