Bug 46946 - The WebSocket server should flush its logs
Summary: The WebSocket server should flush its logs
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-30 17:30 PDT by Adam Barth
Modified: 2010-09-30 23:41 PDT (History)
3 users (show)

See Also:


Attachments
Patch (1.49 KB, patch)
2010-09-30 17:32 PDT, Adam Barth
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2010-09-30 17:30:49 PDT
The WebSocket server should flush its logs
Comment 1 Adam Barth 2010-09-30 17:32:29 PDT
Created attachment 69403 [details]
Patch
Comment 2 Eric Seidel (no email) 2010-09-30 17:36:23 PDT
Comment on attachment 69403 [details]
Patch

I feel like this might get us into other trouble.

It seems the real fix is to fix the third_party code we're using a websocket server.

http://docs.python.org/using/cmdline.html#envvar-PYTHONUNBUFFERED is another way to do the same thing.  Maybe that's clearer?
Comment 3 Eric Seidel (no email) 2010-09-30 17:38:30 PDT
Comment on attachment 69403 [details]
Patch

Seems this should have a FIXME to remove the -u once the third_party stuff is fixed.  Or maybe this is the right long-term solution?  Unclear.  I guess it only affects stdout, stdin, and stderr.
Comment 4 Adam Barth 2010-09-30 17:50:30 PDT
It's not a work around for third_party stuff.  It's because we call terminate process on the server instead of letting it shutdown gracefully.
Comment 5 Adam Barth 2010-09-30 17:51:53 PDT
Environment variables are sadness.
Comment 6 WebKit Commit Bot 2010-09-30 23:41:32 PDT
Comment on attachment 69403 [details]
Patch

Clearing flags on attachment: 69403

Committed r68866: <http://trac.webkit.org/changeset/68866>
Comment 7 WebKit Commit Bot 2010-09-30 23:41:37 PDT
All reviewed patches have been landed.  Closing bug.