WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
46946
The WebSocket server should flush its logs
https://bugs.webkit.org/show_bug.cgi?id=46946
Summary
The WebSocket server should flush its logs
Adam Barth
Reported
2010-09-30 17:30:49 PDT
The WebSocket server should flush its logs
Attachments
Patch
(1.49 KB, patch)
2010-09-30 17:32 PDT
,
Adam Barth
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Adam Barth
Comment 1
2010-09-30 17:32:29 PDT
Created
attachment 69403
[details]
Patch
Eric Seidel (no email)
Comment 2
2010-09-30 17:36:23 PDT
Comment on
attachment 69403
[details]
Patch I feel like this might get us into other trouble. It seems the real fix is to fix the third_party code we're using a websocket server.
http://docs.python.org/using/cmdline.html#envvar-PYTHONUNBUFFERED
is another way to do the same thing. Maybe that's clearer?
Eric Seidel (no email)
Comment 3
2010-09-30 17:38:30 PDT
Comment on
attachment 69403
[details]
Patch Seems this should have a FIXME to remove the -u once the third_party stuff is fixed. Or maybe this is the right long-term solution? Unclear. I guess it only affects stdout, stdin, and stderr.
Adam Barth
Comment 4
2010-09-30 17:50:30 PDT
It's not a work around for third_party stuff. It's because we call terminate process on the server instead of letting it shutdown gracefully.
Adam Barth
Comment 5
2010-09-30 17:51:53 PDT
Environment variables are sadness.
WebKit Commit Bot
Comment 6
2010-09-30 23:41:32 PDT
Comment on
attachment 69403
[details]
Patch Clearing flags on attachment: 69403 Committed
r68866
: <
http://trac.webkit.org/changeset/68866
>
WebKit Commit Bot
Comment 7
2010-09-30 23:41:37 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug