Bug 46929 – [WINCE] Fix InternetGetCookie in CookieJarWin.cpp

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Patrick R. Gansterer]

see patch

[Patrick R. Gansterer]

Created attachment 69365 [details]
Patch

[Adam Roben (:aroben)]

Comment on attachment 69365 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=69365&action=review

> WebCore/platform/network/win/CookieJarWin.cpp:54
> -    DWORD count = str.length() + 1;
> +    DWORD count = 0;
>      InternetGetCookie(str.charactersWithNullTermination(), 0, 0, &count);
>      if (count <= 1) // Null terminator counts as 1.
>          return String();

Why not check the return value of InternetGetCookie, too?

[Patrick R. Gansterer]

(In reply to comment #2)
> Why not check the return value of InternetGetCookie, too?
IMHO it's not required, but I can add it.

[Adam Roben (:aroben)]

(In reply to comment #3)
> (In reply to comment #2)
> > Why not check the return value of InternetGetCookie, too?
> IMHO it's not required, but I can add it.

It seems like a good idea, rather than relying on how the out parameter is treated in failure cases (which MSDN doesn't document).

[Patrick R. Gansterer]

Created attachment 69368 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 69368 [details]
Patch

Clearing flags on attachment: 69368

Committed r68841: <http://trac.webkit.org/changeset/68841>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[WebKit Commit Bot]

Comment on attachment 69368 [details]
Patch

Rejecting patch 69368 from commit-queue.

Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', 'land-attachment', '--force-clean', '--ignore-builders', '--quiet', '--non-interactive', '--parent-command=commit-queue', 69368]" exit_code: 2
Last 500 characters of output:
ipts/svn-apply', u'--reviewer', u'Adam Roben', u'--force']" exit_code: 1
Parsed 2 diffs from patch file(s).
patching file WebCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file WebCore/platform/network/win/CookieJarWin.cpp
Hunk #1 FAILED at 48.
1 out of 1 hunk FAILED -- saving rejects to file WebCore/platform/network/win/CookieJarWin.cpp.rej

Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Adam Roben', u'--force']" exit_code: 1

Full output: http://queues.webkit.org/results/4222021