It looks like Google search for "sunspider" only returns links to 0.9 (unsurprisingly). However there's no indication for people running the 0.9 benchmark that 0.9.1 exists. Given that 0.9 actually tests different things in different browsers (due to the string.replace issue with global replaces), it would be good if it had a prominent notice about not being the current version with a link to 0.9.1.
Created attachment 71518 [details] Update the Sunspider 0.9 html page to point to the new version: 0.9.1. Also added a "previous versions" list such that 0.9 is still available.
Comment on attachment 71518 [details] Update the Sunspider 0.9 html page to point to the new version: 0.9.1. Also added a "previous versions" list such that 0.9 is still available. I don't think this is a great solution to this bug. The fundamental problem here is that we've never put up a version agnostic front page for SunSpider – instead we have a version specific one. Having 'sunspider-0.9/sunspider.html' optionally launch version 0.9.1 isn't particularly clean, and if we leave this as the main page for the benchmark then we continue to propagate a mess into the future – we'll end up with multiple front pages for the benchmark ('sunspider-0.9/sunspider.html', 'sunspider-0.9.1/sunspider.html', etc), all of which can launch multiple variants of the benchmark. I'd suggest that a much better solution would be to try to establish a version-agnostic front page for SunSpider. We should move SunSpider's home to something like 'webkit.org/perf/sunspider/sunspider.html', and make the existing 'sunspider.html's in the sunspider-0.9 & sunspider-0.9.1 directories redirect here. This would keep existing links working, while giving people a better location to link to & bookmark going forwards. This new page could have a button to directly launch current version the current version, and a link to the versions page, that lists all versions. The versions page should also move. It is currently found at 'webkit.org/perf/sunspider-0.9.1/versions.html', however this is clearly nonsensical. It would not make sense for the list of all versions to itself be version-specific. 'versions.html' should move to 'webkit.org/perf/sunspider/versions.html' (alongside the proposed new version-agnostic home for the 'sunspider.html' homepage). (Or alternatively to the last couple of comments, the versions page could be removed, and links to older versions could be included directly on the front page – either way could make sense.)
Created attachment 71603 [details] Create a sunspider landing page, and redirect old pages to it. This could break the sunspider benchmark. We need to test the redirects work as expected as soon as it goes live.
Attachment 71603 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebKitSite/perf/sunspider/sunspider.css:22: Line contains tab character. [whitespace/tab] [5] WebKitSite/perf/sunspider/sunspider.css:23: Line contains tab character. [whitespace/tab] [5] WebKitSite/perf/sunspider/sunspider.css:24: Line contains tab character. [whitespace/tab] [5] WebKitSite/perf/sunspider/sunspider.css:30: Line contains tab character. [whitespace/tab] [5] Total errors found: 4 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 71603 [details] Create a sunspider landing page, and redirect old pages to it. r=me Please be sure to test these links once this patch goes live.
Comment on attachment 71603 [details] Create a sunspider landing page, and redirect old pages to it. Clearing flags on attachment: 71603 Committed r70824: <http://trac.webkit.org/changeset/70824>
All reviewed patches have been landed. Closing bug.
Verified that following the "sunspider 0.9" link from the Google search results or going directly to a bookmark pointing to http://www2.webkit.org/perf/sunspider-0.9/sunspider.html now lands on http://www2.webkit.org/perf/sunspider/sunspider.html and that this last links to 0.9.1 as the current version and 0.9 as a previous version. Thank you for the fix!