Bug 46913 – REGRESSION (r65681): Crash in AccessibilityUIElement::addSelection when running platform/win/accessibility/selection-and-focus.html

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[Adam Roben (:aroben)]

The buildbots are crashing when running platform/win/accessibility/selection-and-focus.html. Looks like a null-dereference. See the URL for the crash log.

[Adam Roben (:aroben)]

<rdar://problem/8497332>

[Adam Roben (:aroben)]

webkit-patch failure-reason blames http://trac.webkit.org/changeset/65681

[Simon Fraser (smfr)]

For some reason,  accessibilityController.focusedElement.childAtIndex(0).takeFocus();
is now focussing the anonymous block that is the select's parent.

[Simon Fraser (smfr)]

I think the test is incorrect. I don't know how it passed before.

[Simon Fraser (smfr)]

Created attachment 69392 [details]
Patch for this and bug 46914.

[WebKit Review Bot]

Attachment 69392 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
LayoutTests/ChangeLog:8:  Line contains tab character.  [whitespace/tab] [5]
LayoutTests/ChangeLog:9:  Line contains tab character.  [whitespace/tab] [5]
LayoutTests/ChangeLog:11:  Line contains tab character.  [whitespace/tab] [5]
LayoutTests/ChangeLog:13:  Line contains tab character.  [whitespace/tab] [5]
LayoutTests/ChangeLog:14:  Line contains tab character.  [whitespace/tab] [5]
LayoutTests/ChangeLog:15:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 6 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Simon Fraser (smfr)]

Created attachment 69396 [details]
Patch

[Jon Honeycutt]

Comment on attachment 69396 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=69396&action=review

> LayoutTests/platform/win/accessibility/selection-and-focus.html:42
> +        

Reduce whitespace! Save the whitespace trees!

[Simon Fraser (smfr)]

http://trac.webkit.org/changeset/68855