Bug 46912 - compositing/geometry/limit-layer-bounds-transformed-overflow.html is flakey
Summary: compositing/geometry/limit-layer-bounds-transformed-overflow.html is flakey
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-30 09:38 PDT by Simon Fraser (smfr)
Modified: 2010-10-06 18:18 PDT (History)
6 users (show)

See Also:

Attachments
Patch (1.63 KB, patch)
2010-10-06 16:14 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2010-09-30 09:38:25 PDT 
compositing/geometry/limit-layer-bounds-transformed-overflow.html is flakey on the bots, e.g.
http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(Tests)/r68788%20(18524)/results.html
Comment 1 Adam Barth 2010-10-06 16:14:53 PDT 
Created attachment 70003 [details]
Patch
Comment 2 James Robinson 2010-10-06 16:21:35 PDT 
The theory here is that the tiling flag (m_usingTiledLayer) is only being set from calls to GraphicsLayerCA::syncCompositingState(), which is called whenever FrameView::paintContents() is called or when the layerSyncRunLoopObserverCallBack in WebView.mm is called.  We suspect that since this test doesn't specifically request a paint, that sometimes the test runs without syncCompositingState() being called and forcing the tiled flag to be set.  I don't know if that really makes sense or not.  The layer size seems correct.

WDYT Simon?
Comment 3 Simon Fraser (smfr) 2010-10-06 16:24:40 PDT 
Comment on attachment 70003 [details]
Patch

That's exactly the change I would have made. Sorry I didn't get to this.
Comment 4 WebKit Commit Bot 2010-10-06 18:18:40 PDT 
Comment on attachment 70003 [details]
Patch

Clearing flags on attachment: 70003

Committed r69265: <http://trac.webkit.org/changeset/69265>
Comment 5 WebKit Commit Bot 2010-10-06 18:18:45 PDT 
All reviewed patches have been landed.  Closing bug.