WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
46912
compositing/geometry/limit-layer-bounds-transformed-overflow.html is flakey
https://bugs.webkit.org/show_bug.cgi?id=46912
Summary
compositing/geometry/limit-layer-bounds-transformed-overflow.html is flakey
Simon Fraser (smfr)
Reported
2010-09-30 09:38:25 PDT
compositing/geometry/limit-layer-bounds-transformed-overflow.html is flakey on the bots, e.g.
http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(Tests)/r68788%20(18524)/results.html
Attachments
Patch
(1.63 KB, patch)
2010-10-06 16:14 PDT
,
Adam Barth
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Adam Barth
Comment 1
2010-10-06 16:14:53 PDT
Created
attachment 70003
[details]
Patch
James Robinson
Comment 2
2010-10-06 16:21:35 PDT
The theory here is that the tiling flag (m_usingTiledLayer) is only being set from calls to GraphicsLayerCA::syncCompositingState(), which is called whenever FrameView::paintContents() is called or when the layerSyncRunLoopObserverCallBack in WebView.mm is called. We suspect that since this test doesn't specifically request a paint, that sometimes the test runs without syncCompositingState() being called and forcing the tiled flag to be set. I don't know if that really makes sense or not. The layer size seems correct. WDYT Simon?
Simon Fraser (smfr)
Comment 3
2010-10-06 16:24:40 PDT
Comment on
attachment 70003
[details]
Patch That's exactly the change I would have made. Sorry I didn't get to this.
WebKit Commit Bot
Comment 4
2010-10-06 18:18:40 PDT
Comment on
attachment 70003
[details]
Patch Clearing flags on attachment: 70003 Committed
r69265
: <
http://trac.webkit.org/changeset/69265
>
WebKit Commit Bot
Comment 5
2010-10-06 18:18:45 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug