RESOLVED FIXED46906
Rename get* and open*Cursor per the spec on IDBIndex 
https://bugs.webkit.org/show_bug.cgi?id=46906
Summary Rename get* and open*Cursor per the spec on IDBIndex
Jeremy Orlow
Reported 2010-09-30 08:49:42 PDT
The spec changed so that: IDBIndex.get -> getKey IDBIndex.getObject -> get IDBIndex.openCursor -> openKeyCursor IDBIndex.openObjectCursor -> openCursor
Attachments
patch (28.25 KB, patch)
2010-09-30 08:51 PDT, Jeremy Orlow 		no flags
DetailsFormatted DiffDiff
Patch (29.40 KB, patch)
2010-10-04 14:38 PDT, Jeremy Orlow 		japhet: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jeremy Orlow
Comment 1 2010-09-30 08:51:56 PDT
Created attachment 69339 [details] patch
Andrei Popescu
Comment 2 2010-09-30 09:33:33 PDT
LGTM
Steve Block
Comment 3 2010-10-01 09:11:10 PDT
Comment on attachment 69339 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=69339&action=review > WebCore/ChangeLog:13 > + Should mention the tests that cover this > WebKit/chromium/public/WebIDBIndex.h:68 > + openKeyCursor(range, direction, callbacks, transaction); Should we call openObjectCursor()? > WebKit/chromium/public/WebIDBIndex.h:77 > + getKey(range, callbacks, transaction); Shouldn't we call getObject()?
Jeremy Orlow
Comment 4 2010-10-04 13:37:47 PDT
(In reply to comment #3) > (From update of attachment 69339 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=69339&action=review > > > WebCore/ChangeLog:13 > > + > > Should mention the tests that cover this Will do. > > WebKit/chromium/public/WebIDBIndex.h:68 > > + openKeyCursor(range, direction, callbacks, transaction); > > Should we call openObjectCursor()? > > > WebKit/chromium/public/WebIDBIndex.h:77 > > + getKey(range, callbacks, transaction); > > Shouldn't we call getObject()? Nope..this is temp code to get around webkit roll issues. What currently (in chromium) is ___ should be ___Key
Jeremy Orlow
Comment 5 2010-10-04 14:38:17 PDT
Created attachment 69684 [details] Patch
Jeremy Orlow
Comment 6 2010-10-05 10:17:54 PDT
Committed r69123: <http://trac.webkit.org/changeset/69123>
Note You need to log in before you can comment on or make changes to this bug.