Bug 46891 - Many tests in webkitpy.tool.bot.queueengine_unittest.QueueEngineTest crash on Windows
Summary: Many tests in webkitpy.tool.bot.queueengine_unittest.QueueEngineTest crash on...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P2 Normal
Assignee: Adam Roben (:aroben)
URL: http://build.webkit.org/builders/Wind...
Keywords: InRadar, PlatformOnly
Depends on:
Blocks:
 
Reported: 2010-09-30 06:11 PDT by Adam Roben (:aroben)
Modified: 2010-09-30 09:41 PDT (History)
3 users (show)

See Also:


Attachments
Ensure that QueueEngine cleans up its log files when its delegate tells it to stop processing work (5.58 KB, patch)
2010-09-30 06:21 PDT, Adam Roben (:aroben)
abarth: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2010-09-30 06:11:16 PDT
See URL for failures like this:


ERROR: test_handled_error (webkitpy.tool.bot.queueengine_unittest.QueueEngineTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/buildbot/slave/win-debug-tests/build/WebKitTools/Scripts/webkitpy/tool/bot/queueengine_unittest.py", line 207, in tearDown
    shutil.rmtree(self.temp_dir)
  File "/usr/lib/python2.5/shutil.py", line 178, in rmtree
    onerror(os.rmdir, path, sys.exc_info())
  File "/usr/lib/python2.5/shutil.py", line 176, in rmtree
    os.rmdir(path)
OSError: [Errno 90] Directory not empty: '/cygdrive/c/DOCUME~1/buildbot/LOCALS~1/Temp/tmpWpOrjbwork_queue_test_logs'
Comment 1 Adam Roben (:aroben) 2010-09-30 06:13:23 PDT
<rdar://problem/8496638>
Comment 2 Adam Roben (:aroben) 2010-09-30 06:21:38 PDT
Created attachment 69329 [details]
Ensure that QueueEngine cleans up its log files when its delegate tells it to stop processing work
Comment 3 WebKit Review Bot 2010-09-30 06:23:13 PDT
Attachment 69329 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKitTools/Scripts/webkitpy/tool/bot/queueengine_unittest.py:57:  whitespace before ']'  [pep8/E202] [5]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Adam Barth 2010-09-30 09:18:47 PDT
Comment on attachment 69329 [details]
Ensure that QueueEngine cleans up its log files when its delegate tells it to stop processing work

View in context: https://bugs.webkit.org/attachment.cgi?id=69329&action=review

thanks!

> WebKitTools/Scripts/webkitpy/tool/bot/queueengine_unittest.py:57
> +        'stop_work_queue'

The style bot wants you to put a , after this line.
Comment 5 Adam Roben (:aroben) 2010-09-30 09:41:47 PDT
Committed r68793: <http://trac.webkit.org/changeset/68793>