Bug 46891 – Many tests in webkitpy.tool.bot.queueengine_unittest.QueueEngineTest crash on Windows

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Adam Roben (:aroben)]

See URL for failures like this:


ERROR: test_handled_error (webkitpy.tool.bot.queueengine_unittest.QueueEngineTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/buildbot/slave/win-debug-tests/build/WebKitTools/Scripts/webkitpy/tool/bot/queueengine_unittest.py", line 207, in tearDown
    shutil.rmtree(self.temp_dir)
  File "/usr/lib/python2.5/shutil.py", line 178, in rmtree
    onerror(os.rmdir, path, sys.exc_info())
  File "/usr/lib/python2.5/shutil.py", line 176, in rmtree
    os.rmdir(path)
OSError: [Errno 90] Directory not empty: '/cygdrive/c/DOCUME~1/buildbot/LOCALS~1/Temp/tmpWpOrjbwork_queue_test_logs'

[Adam Roben (:aroben)]

<rdar://problem/8496638>

[Adam Roben (:aroben)]

Created attachment 69329 [details]
Ensure that QueueEngine cleans up its log files when its delegate tells it to stop processing work

[WebKit Review Bot]

Attachment 69329 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKitTools/Scripts/webkitpy/tool/bot/queueengine_unittest.py:57:  whitespace before ']'  [pep8/E202] [5]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Adam Barth]

Comment on attachment 69329 [details]
Ensure that QueueEngine cleans up its log files when its delegate tells it to stop processing work

View in context: https://bugs.webkit.org/attachment.cgi?id=69329&action=review

thanks!

> WebKitTools/Scripts/webkitpy/tool/bot/queueengine_unittest.py:57
> +        'stop_work_queue'

The style bot wants you to put a , after this line.

[Adam Roben (:aroben)]

Committed r68793: <http://trac.webkit.org/changeset/68793>