Bug 46889 – xml:space attribute is not mapped to its corresponding CSS property for all SVG*Elements except SVGTextContentElement

• Status: RESOLVED
• Resolution: INVALID
• Component: SVG

[Nikolas Zimmermann]

The bug is not visible right now, but without this patch the new text layout engine won't work properly. xml:lang="preserve" is not propagated across elements.
Eg <g xml:space="preserve"><text...> doesn't affect the <text> element in the new layout engine.

[Nikolas Zimmermann]

s/xml:lang/xml:space/ oops!

[Nikolas Zimmermann]

Created attachment 69327 [details]
Patch

[Dirk Schulze]

Why can't it get covered by a test right now?

[Nikolas Zimmermann]

(In reply to comment #3)
> Why can't it get covered by a test right now?

You're right! The bug is probably present already, I need a fresh build with only this patch applied, to see if it changes results.

Sorry, didn't think about it earlier.

[Dirk Schulze]

Comment on attachment 69327 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=69327&action=review

PLeae comment why you can't test it with a new test and fix the style issue.

> WebCore/svg/SVGTextPositioningElement.cpp:163
> +    if (!node->hasTagName(SVGNames::textTag)
> +     && !node->hasTagName(SVGNames::tspanTag)
> +#if ENABLE(SVG_FONTS)
> +     && !node->hasTagName(SVGNames::altGlyphTag)
> +#endif
> +     && !node->hasTagName(SVGNames::trefTag))

wrong indention.

[Nikolas Zimmermann]

Comment on attachment 69327 [details]
Patch

Clearing review flag. Thanks Dirk, the patch is obsolete now!