Bug 46884 - [chromium] add an identifier method to WebFrame
Summary: [chromium] add an identifier method to WebFrame
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: jochen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-30 02:24 PDT by jochen
Modified: 2010-10-01 01:06 PDT (History)
2 users (show)

See Also:


Attachments
Patch (3.51 KB, patch)
2010-09-30 02:24 PDT, jochen
no flags Details | Formatted Diff | Diff
Patch (3.54 KB, patch)
2010-10-01 00:41 PDT, jochen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description jochen 2010-09-30 02:24:03 PDT
[chromium] add an identifier method to WebFrame
Comment 1 jochen 2010-09-30 02:24:27 PDT
Created attachment 69320 [details]
Patch
Comment 2 Darin Fisher (:fishd, Google) 2010-09-30 11:19:27 PDT
Comment on attachment 69320 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=69320&action=review

> WebKit/chromium/ChangeLog:5
> +        [chromium] add an identifier method to WebFrame

please add some explanation here about why this is important.  please document what kind
of constraints you have on this identifier.  that way people in the future will understand
what they can and can't change about this identifier field.

> WebKit/chromium/src/WebFrameImpl.cpp:267
> +    // identifiers that overlap with those from past/future browser sessions.

making these IDs unique across browser sessions is not a requirement is it?
Comment 3 jochen 2010-10-01 00:41:46 PDT
Created attachment 69429 [details]
Patch
Comment 4 WebKit Commit Bot 2010-10-01 01:06:26 PDT
Comment on attachment 69429 [details]
Patch

Clearing flags on attachment: 69429

Committed r68871: <http://trac.webkit.org/changeset/68871>
Comment 5 WebKit Commit Bot 2010-10-01 01:06:30 PDT
All reviewed patches have been landed.  Closing bug.