Bug 46863 - glsl-conformance.html on khronos will crash chromium --in-process-webgl
Summary: glsl-conformance.html on khronos will crash chromium --in-process-webgl
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Zhenyao Mo
URL:
Keywords:
Depends on: 44309
Blocks:
  Show dependency tree / graph
 
Reported: 2010-09-29 18:23 PDT by Zhenyao Mo
Modified: 2010-09-30 11:13 PDT (History)
2 users (show)

See Also:

Attachments
patch (76.94 KB, patch)
2010-09-29 18:29 PDT, Zhenyao Mo 		kbr: review+
zmo: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zhenyao Mo 2010-09-29 18:23:50 PDT 
It's due to the HashMap resizing not being handled properly in WebGraphicsContextDefaultImpl.cpp
Comment 1 Zhenyao Mo 2010-09-29 18:29:59 PDT 
Created attachment 69290 [details]
patch

The test is copied from khronos and slightly modified (turn off console logging).
Comment 2 Kenneth Russell 2010-09-29 18:49:15 PDT 
It's unfortunate there isn't a better pattern for this but after searching through WebCore I see this pattern of HashMaps with pointers as the values in several places.

Just to verify before r+'ing: the new test was run with WebKit as well as Chromium?
Comment 3 Zhenyao Mo 2010-09-29 19:30:15 PDT 
Yes, tested in both Safari and Chromium.
Comment 4 Kenneth Russell 2010-09-30 10:48:50 PDT 
Comment on attachment 69290 [details]
patch

OK. Looks good to me.
Comment 5 Zhenyao Mo 2010-09-30 11:13:08 PDT 
Committed r68806: <http://trac.webkit.org/changeset/68806>