WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
46852
Build fix: Add ENABLE(INSPECTOR) guard
https://bugs.webkit.org/show_bug.cgi?id=46852
Summary
Build fix: Add ENABLE(INSPECTOR) guard
Kwang Yul Seo
Reported
2010-09-29 16:28:34 PDT
Page does not have inspectorController() when ENABLE(INSPECTOR) is 0.
Attachments
Patch
(1.31 KB, patch)
2010-09-29 16:29 PDT
,
Kwang Yul Seo
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Kwang Yul Seo
Comment 1
2010-09-29 16:29:46 PDT
Created
attachment 69274
[details]
Patch
Darin Adler
Comment 2
2010-09-29 16:37:08 PDT
Comment on
attachment 69274
[details]
Patch Seems this would be better if you wrapped even more of the function in the #if. It’s strange to look up a page to just return 0.
WebKit Commit Bot
Comment 3
2010-09-30 01:22:29 PDT
Comment on
attachment 69274
[details]
Patch Clearing flags on attachment: 69274 Committed
r68763
: <
http://trac.webkit.org/changeset/68763
>
WebKit Commit Bot
Comment 4
2010-09-30 01:22:33 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug