Bug 46838 - Get rid of marginStartUsing/setMarginStartUsing on RenderBox
Summary: Get rid of marginStartUsing/setMarginStartUsing on RenderBox
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Dave Hyatt
URL:
Keywords:
Depends on:
Blocks: 46123
  Show dependency tree / graph
 
Reported: 2010-09-29 14:15 PDT by Dave Hyatt
Modified: 2010-09-29 14:45 PDT (History)
0 users

See Also:

Attachments
Patch (18.12 KB, patch)
2010-09-29 14:20 PDT, Dave Hyatt 		no flags Details | Formatted Diff | Diff
Patch (18.40 KB, patch)
2010-09-29 14:25 PDT, Dave Hyatt 		simon.fraser: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Hyatt 2010-09-29 14:15:06 PDT 
Get rid of marginStartUsing/setMarginStartUsing on RenderBox (and before/after/end).  It's cleaner to invert the relationship and make the methods be on the containing block instead.  This also allows the getters to work with RenderInlines.
Comment 1 Dave Hyatt 2010-09-29 14:20:42 PDT 
Created attachment 69247 [details]
Patch
Comment 2 Dave Hyatt 2010-09-29 14:25:49 PDT 
Created attachment 69248 [details]
Patch
Comment 3 Dave Hyatt 2010-09-29 14:45:51 PDT 
Fixed in r68687.