Bug 46803 - [v8] Use generic mechanism to report exceptions in V8CustomVoidCallback
Summary: [v8] Use generic mechanism to report exceptions in V8CustomVoidCallback
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Yury Semikhatsky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-29 06:12 PDT by Yury Semikhatsky
Modified: 2010-09-29 06:47 PDT (History)
5 users (show)

See Also:

Attachments
Patch (2.04 KB, patch)
2010-09-29 06:16 PDT, Yury Semikhatsky 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yury Semikhatsky 2010-09-29 06:12:54 PDT 
At the moment it uses custom call to ScriptExecutionContext::reportException while the exceptions should be reported in a regular way using V8 message listener set in V8DOMWindowShell::initContextIfNeeded.
Comment 1 Yury Semikhatsky 2010-09-29 06:16:44 PDT 
Created attachment 69185 [details]
Patch
Comment 2 anton muhin 2010-09-29 06:20:15 PDT 
Comment on attachment 69185 [details]
Patch

LGTM, much nicer
Comment 3 WebKit Commit Bot 2010-09-29 06:47:01 PDT 
Comment on attachment 69185 [details]
Patch

Clearing flags on attachment: 69185

Committed r68641: <http://trac.webkit.org/changeset/68641>
Comment 4 WebKit Commit Bot 2010-09-29 06:47:06 PDT 
All reviewed patches have been landed.  Closing bug.