Bug 46798 - Assertion failed when accessing -webkit-margin-top-collapse via computed style
Summary: Assertion failed when accessing -webkit-margin-top-collapse via computed style
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-29 04:42 PDT by Hajime Morrita
Modified: 2010-09-29 15:05 PDT (History)
5 users (show)

See Also:


Attachments
Patch (7.83 KB, patch)
2010-09-29 04:55 PDT, Hajime Morrita
eric: review+
senorblanco: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hajime Morrita 2010-09-29 04:42:40 PDT
This looks to be introduced at http://trac.webkit.org/changeset/68561. 
Compilers could warn this when disabling SVG.
Comment 1 Hajime Morrita 2010-09-29 04:55:51 PDT
Created attachment 69178 [details]
Patch
Comment 2 Hajime Morrita 2010-09-29 04:57:32 PDT
Adding CC to notify this regression.
Comment 3 Eric Seidel (no email) 2010-09-29 12:46:36 PDT
Comment on attachment 69178 [details]
Patch

This is *exactly* why we kill those evil default: statements.  Thank you!
Comment 4 Eric Seidel (no email) 2010-09-29 12:46:57 PDT
Comment on attachment 69178 [details]
Patch

We'll let this commit while you sleep.
Comment 5 Stephen White 2010-09-29 14:59:58 PDT
This is preventing any chromium mac trybots from compiling, so I'm going to land manually.
Comment 6 Stephen White 2010-09-29 15:03:04 PDT
Committed r68690: <http://trac.webkit.org/changeset/68690>
Comment 7 Eric Seidel (no email) 2010-09-29 15:05:32 PDT
Yup.  The WebKit tree has been red all afternoon, blocking the commit-queue.

You don't actually need to set cq-, the commit-queue bot will figure it out if you have already landed the patch.  It checks to make sure the bug is still open before actually trying to land (and if I tried to land double, it would just get a git commit error anyway).

Thanks.