Bug 46795 – build still broken since r68521

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Philippe Normand]

Martin did an attempt to fix it with r68550 but it still fails.

[Philippe Normand]

Created attachment 69175 [details]
proposed build fix

[Philippe Normand]

Commited http://trac.webkit.org/changeset/68645 after discussion on IRC with kov, Ossy and bbandix.

Leaving opened for now.

[Csaba Osztrogonác]

Created attachment 69211 [details]
proposed proper fix

I think the landed patch is incorrect:

foo1.c:
foo2.c: dependency1.c dependency2.c
        receipe_to_make_foo1_and_foo2

--> Here "foo1.c:" is an empty rule and we don't want this.

[Darin Adler]

(In reply to comment #3)
> I think the landed patch is incorrect:
> 
> foo1.c:
> foo2.c: dependency1.c dependency2.c
>         receipe_to_make_foo1_and_foo2
> 
> --> Here "foo1.c:" is an empty rule and we don't want this.

Yes, I agree.

[Andras Becsi]

(In reply to comment #3)
> Created an attachment (id=69211) [details]
> proposed proper fix

LGTM. With the empty rule we have the same effect as without Martin's patch. Thanks for fixing this.

[Martin Robinson]

Comment on attachment 69211 [details]
proposed proper fix

Thank you!

[Csaba Osztrogonác]

Comment on attachment 69211 [details]
proposed proper fix

Clearing flags on attachment: 69211

Committed r68787: <http://trac.webkit.org/changeset/68787>

[Csaba Osztrogonác]

All reviewed patches have been landed.  Closing bug.