Bug 46795 - build still broken since r68521
Summary: build still broken since r68521
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-29 03:58 PDT by Philippe Normand
Modified: 2010-09-30 08:46 PDT (History)
6 users (show)

See Also:

Attachments
proposed build fix (1.84 KB, patch)
2010-09-29 04:00 PDT, Philippe Normand 		no flags Details | Formatted Diff | Diff
proposed proper fix (2.68 KB, patch)
2010-09-29 10:34 PDT, Csaba Osztrogonác 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2010-09-29 03:58:04 PDT 
Martin did an attempt to fix it with r68550 but it still fails.
Comment 1 Philippe Normand 2010-09-29 04:00:38 PDT 
Created attachment 69175 [details]
proposed build fix
Comment 2 Philippe Normand 2010-09-29 08:13:28 PDT 
Commited http://trac.webkit.org/changeset/68645 after discussion on IRC with kov, Ossy and bbandix.

Leaving opened for now.
Comment 3 Csaba Osztrogonác 2010-09-29 10:34:52 PDT 
Created attachment 69211 [details]
proposed proper fix

I think the landed patch is incorrect:

foo1.c:
foo2.c: dependency1.c dependency2.c
        receipe_to_make_foo1_and_foo2

--> Here "foo1.c:" is an empty rule and we don't want this.
Comment 4 Darin Adler 2010-09-29 10:40:12 PDT 
(In reply to comment #3)
> I think the landed patch is incorrect:
> 
> foo1.c:
> foo2.c: dependency1.c dependency2.c
>         receipe_to_make_foo1_and_foo2
> 
> --> Here "foo1.c:" is an empty rule and we don't want this.

Yes, I agree.
Comment 5 Andras Becsi 2010-09-30 02:04:42 PDT 
(In reply to comment #3)
> Created an attachment (id=69211) [details]
> proposed proper fix

LGTM. With the empty rule we have the same effect as without Martin's patch. Thanks for fixing this.
Comment 6 Martin Robinson 2010-09-30 08:38:11 PDT 
Comment on attachment 69211 [details]
proposed proper fix

Thank you!
Comment 7 Csaba Osztrogonác 2010-09-30 08:45:52 PDT 
Comment on attachment 69211 [details]
proposed proper fix

Clearing flags on attachment: 69211

Committed r68787: <http://trac.webkit.org/changeset/68787>
Comment 8 Csaba Osztrogonác 2010-09-30 08:46:02 PDT 
All reviewed patches have been landed.  Closing bug.