Bug 46790 – GStreamer PlatformVideoWindow needs an API to prepare the widget before applying the overlay

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Philippe Normand]

On Mac OSX, the osxvideosink sends a message on the GStreamer bus which includes a pointer to its internal NSView. Application-side needs to retrieve and use it before calling the XOverlay set_window_handle function.

So I propose to add a simple "prepare(GstMessage*)" method in PlatformVideoWindow for this purpose.
On Gtk and EFL this would be an empty implementation.

[Philippe Normand]

Created attachment 69176 [details]
proposed patch

[Martin Robinson]

Comment on attachment 69176 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=69176&action=review

I'm not sure what an appropriate name for this method should be (perhaps prepareForOverlay?), but I think that prepare is not descriptive enough.

> WebCore/platform/graphics/gstreamer/GStreamerGWorld.cpp:198
> +        m_videoWindow->prepare(message);

The name prepare(...) seems a little ambiguous. I would prefer something a bit more descriptive.

> WebCore/platform/graphics/gstreamer/PlatformVideoWindowEfl.cpp:40
> +    notImplemented();

An empty implementation is different than notImplemented(). This should just be empty.

> WebCore/platform/graphics/gstreamer/PlatformVideoWindowGtk.cpp:69
> +    notImplemented();

Same here.

[Eric Seidel (no email)]

Attachment 69176 [details] was posted by a committer and has review+, assigning to Philippe Normand for commit.

[Philippe Normand]

Committed r70048: <http://trac.webkit.org/changeset/70048>