Bug 46789 - Web Inspector: assign the resourceLoad finish time which was obtained from the network stack as the end time for the corresponding event in Timeline.
Summary: Web Inspector: assign the resourceLoad finish time which was obtained from th...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Ilya Tikhonovsky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-29 00:51 PDT by Ilya Tikhonovsky
Modified: 2010-09-30 05:49 PDT (History)
10 users (show)

See Also:


Attachments
[patch] First iteration. (3.72 KB, patch)
2010-09-29 00:56 PDT, Ilya Tikhonovsky
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ilya Tikhonovsky 2010-09-29 00:51:49 PDT
See related change for Resources panel https://bugs.webkit.org/show_bug.cgi?id=45664
Comment 1 Ilya Tikhonovsky 2010-09-29 00:56:18 PDT
Created attachment 69168 [details]
[patch] First iteration.
Comment 2 Yury Semikhatsky 2010-09-29 01:03:27 PDT
Comment on attachment 69168 [details]
[patch] First iteration.

View in context: https://bugs.webkit.org/attachment.cgi?id=69168&action=review

> WebCore/inspector/InspectorTimelineAgent.cpp:248
> +    RefPtr<InspectorObject> record = TimelineRecordFactory::createGenericRecord(finishTime ? finishTime : WTF::currentTimeMS());

I don't quite understand why we not use finishTime in all cases?
Comment 3 Ilya Tikhonovsky 2010-09-30 05:48:45 PDT
Committed r68779
	M	WebCore/ChangeLog
	M	WebCore/inspector/InspectorController.cpp
	M	WebCore/inspector/InspectorTimelineAgent.cpp
	M	WebCore/inspector/InspectorTimelineAgent.h
r68779 = 28059cde085c595f4c6f4c8c40d411ba472717db (refs/remotes/trunk)