Bug 46788 - check for ENABLE(GLIB_SUPPORT) in WebView
Summary: check for ENABLE(GLIB_SUPPORT) in WebView
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-29 00:50 PDT by Philippe Normand
Modified: 2010-10-05 08:32 PDT (History)
1 user (show)

See Also:

Attachments
proposed patch (2.64 KB, patch)
2010-09-29 00:54 PDT, Philippe Normand 		no flags Details | Formatted Diff | Diff
proposed patch (3.69 KB, patch)
2010-09-29 05:37 PDT, Philippe Normand 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2010-09-29 00:50:15 PDT 
WebView.mm contains a small runloop observer used to trigger the main glib context iterations. That code is guarded with ENABLE(VIDEO) && USE(GSTREAMER). It would make more sense to guard it with ENABLE(GLIB_SUPPORT) instead because it's not specific to video or gstreamer support in the end.
Comment 1 Philippe Normand 2010-09-29 00:54:09 PDT 
Created attachment 69167 [details]
proposed patch
Comment 2 Philippe Normand 2010-09-29 05:37:04 PDT 
Created attachment 69181 [details]
proposed patch
Comment 3 Martin Robinson 2010-10-02 11:24:06 PDT 
Comment on attachment 69181 [details]
proposed patch

Looks reasonable!
Comment 4 WebKit Commit Bot 2010-10-05 08:32:39 PDT 
Comment on attachment 69181 [details]
proposed patch

Clearing flags on attachment: 69181

Committed r69109: <http://trac.webkit.org/changeset/69109>
Comment 5 WebKit Commit Bot 2010-10-05 08:32:44 PDT 
All reviewed patches have been landed.  Closing bug.