Bug 46772 - [EFL] Viewport data change notification by Bug 46755
Summary: [EFL] Viewport data change notification by Bug 46755
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 46755
Blocks: 47084
  Show dependency treegraph
 
Reported: 2010-09-28 18:54 PDT by Gyuyoung Kim
Modified: 2010-10-04 20:44 PDT (History)
6 users (show)

See Also:


Attachments
Patch (3.23 KB, patch)
2010-10-04 06:33 PDT, Gyuyoung Kim
kenneth: review+
kenneth: commit-queue-
Details | Formatted Diff | Diff
Patch (4.65 KB, patch)
2010-10-04 07:20 PDT, Gyuyoung Kim
kenneth: review+
kenneth: commit-queue+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2010-09-28 18:54:58 PDT
Bug 46755 (Viewport data change notification) will change viewport header function. So, I think that EFL port need to support the change.
Comment 1 Gyuyoung Kim 2010-10-04 06:33:36 PDT
Created attachment 69628 [details]
Patch
Comment 2 Gyuyoung Kim 2010-10-04 06:43:30 PDT
I modify viewport functions in efl port according to Bug 46755.

Rafael removed xxxinitLayoutComplete() in Bug 46722. Because, he said the feature is not needed anymore.

I remember that the functions are to prevent re-layouting. Does Qt port still use this ?

For the time being, I remove the function definitions related to initial layout complete.
Comment 3 Kenneth Rohde Christiansen 2010-10-04 06:44:41 PDT
Comment on attachment 69628 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=69628&action=review

> WebKit/efl/WebCoreSupport/ChromeClientEfl.cpp:520
>      ewk_view_viewport_set(m_view, arguments.width, arguments.height, arguments.initialScale, arguments.minimumScale, arguments.maximumScale, arguments.userScalable);

don't you guys want the DPI adjustment?

> WebKit/efl/WebCoreSupport/FrameLoaderClientEfl.h:-59
> -    bool getInitLayoutCompleted() { return m_initLayoutCompleted; }

don't you need to remove the m_initLayoutCompleted variable as well?
Comment 4 Kenneth Rohde Christiansen 2010-10-04 06:45:48 PDT
(In reply to comment #3)
> (From update of attachment 69628 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=69628&action=review
> 
> > WebKit/efl/WebCoreSupport/ChromeClientEfl.cpp:520
> >      ewk_view_viewport_set(m_view, arguments.width, arguments.height, arguments.initialScale, arguments.minimumScale, arguments.maximumScale, arguments.userScalable);
> 
> don't you guys want the DPI adjustment?
> 
> > WebKit/efl/WebCoreSupport/FrameLoaderClientEfl.h:-59
> > -    bool getInitLayoutCompleted() { return m_initLayoutCompleted; }
> 
> don't you need to remove the m_initLayoutCompleted variable as well?

The new method is now called at the right time so this is not needed anymore.
Comment 5 Gyuyoung Kim 2010-10-04 06:52:16 PDT
(In reply to comment #3)
> (From update of attachment 69628 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=69628&action=review
> 

> don't you guys want the DPI adjustment?

Ah, I just made a new bug(Bug 47084) for DPI. Because, in order to use DPI, EWebLauncher needs to modify as well. I need time.

>> The new method is now called at the right time so this is not needed anymore.

I understand that the functions related to initLayoutcomplte are not needed anymore. right?
Comment 6 Kenneth Rohde Christiansen 2010-10-04 06:57:43 PDT
> I understand that the functions related to initLayoutcomplte are not needed anymore. right?

right
Comment 7 Gyuyoung Kim 2010-10-04 07:00:05 PDT
Do you want the targetDensityDpi is supported in this bug ? I should modify both ewk_view.cpp and EWebLauncher/main.cpp. I need to consider the targetDensityDpi arguments further.
Comment 8 Gyuyoung Kim 2010-10-04 07:20:43 PDT
Created attachment 69632 [details]
Patch

I didn't remove member variable(m_iniLAyoutcompleted). I make a new patch for it.
Comment 9 Kenneth Rohde Christiansen 2010-10-04 07:22:18 PDT
You really want to change your code to call the new WebCore::findConfigurationForViewportData to compute the right data for you, instead of just exposing what the web author set.
Comment 10 Adam Barth 2010-10-04 20:44:00 PDT
Committed r69061: <http://trac.webkit.org/changeset/69061>