Bug 46772 – [EFL] Viewport data change notification by Bug 46755

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Gyuyoung Kim]

Bug 46755 (Viewport data change notification) will change viewport header function. So, I think that EFL port need to support the change.

[Gyuyoung Kim]

Created attachment 69628 [details]
Patch

[Gyuyoung Kim]

I modify viewport functions in efl port according to Bug 46755.

Rafael removed xxxinitLayoutComplete() in Bug 46722. Because, he said the feature is not needed anymore.

I remember that the functions are to prevent re-layouting. Does Qt port still use this ?

For the time being, I remove the function definitions related to initial layout complete.

[Kenneth Rohde Christiansen]

Comment on attachment 69628 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=69628&action=review

> WebKit/efl/WebCoreSupport/ChromeClientEfl.cpp:520
>      ewk_view_viewport_set(m_view, arguments.width, arguments.height, arguments.initialScale, arguments.minimumScale, arguments.maximumScale, arguments.userScalable);

don't you guys want the DPI adjustment?

> WebKit/efl/WebCoreSupport/FrameLoaderClientEfl.h:-59
> -    bool getInitLayoutCompleted() { return m_initLayoutCompleted; }

don't you need to remove the m_initLayoutCompleted variable as well?

[Kenneth Rohde Christiansen]

(In reply to comment #3)
> (From update of attachment 69628 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=69628&action=review
> 
> > WebKit/efl/WebCoreSupport/ChromeClientEfl.cpp:520
> >      ewk_view_viewport_set(m_view, arguments.width, arguments.height, arguments.initialScale, arguments.minimumScale, arguments.maximumScale, arguments.userScalable);
> 
> don't you guys want the DPI adjustment?
> 
> > WebKit/efl/WebCoreSupport/FrameLoaderClientEfl.h:-59
> > -    bool getInitLayoutCompleted() { return m_initLayoutCompleted; }
> 
> don't you need to remove the m_initLayoutCompleted variable as well?

The new method is now called at the right time so this is not needed anymore.

[Gyuyoung Kim]

(In reply to comment #3)
> (From update of attachment 69628 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=69628&action=review
> 

> don't you guys want the DPI adjustment?

Ah, I just made a new bug(Bug 47084) for DPI. Because, in order to use DPI, EWebLauncher needs to modify as well. I need time.

>> The new method is now called at the right time so this is not needed anymore.

I understand that the functions related to initLayoutcomplte are not needed anymore. right?

[Kenneth Rohde Christiansen]

> I understand that the functions related to initLayoutcomplte are not needed anymore. right?

right

[Gyuyoung Kim]

Do you want the targetDensityDpi is supported in this bug ? I should modify both ewk_view.cpp and EWebLauncher/main.cpp. I need to consider the targetDensityDpi arguments further.

[Gyuyoung Kim]

Created attachment 69632 [details]
Patch

I didn't remove member variable(m_iniLAyoutcompleted). I make a new patch for it.

[Kenneth Rohde Christiansen]

You really want to change your code to call the new WebCore::findConfigurationForViewportData to compute the right data for you, instead of just exposing what the web author set.

[Adam Barth]

Committed r69061: <http://trac.webkit.org/changeset/69061>