Bug 46769 - Bundle should expose a reportException method
Summary: Bundle should expose a reportException method
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Jessie Berlin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-28 17:06 PDT by Jessie Berlin
Modified: 2010-10-07 07:59 PDT (History)
2 users (show)

See Also:

Attachments
Add InjectedBundle::reportException (3.81 KB, patch)
2010-10-06 18:32 PDT, Jessie Berlin 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jessie Berlin 2010-09-28 17:06:28 PDT 
There should be a WKBundleReportException analogous to WebView::reportException.
Comment 1 Jessie Berlin 2010-10-06 15:32:04 PDT 
<rdar://problem/8521276>
Comment 2 Jessie Berlin 2010-10-06 18:32:20 PDT 
Created attachment 70023 [details]
Add InjectedBundle::reportException
Comment 3 John Sullivan 2010-10-06 21:11:30 PDT 
Comment on attachment 70023 [details]
Add InjectedBundle::reportException

View in context: https://bugs.webkit.org/attachment.cgi?id=70023&action=review

> WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp:232
> +    // Make sure the context has a DOMWindow global object, otherwise this context didn't originate from a View.

I'm not sure if View with a capital V refers to a class or a named concept. Maybe this comment could be improved.
Comment 4 Jessie Berlin 2010-10-07 06:04:36 PDT 
(In reply to comment #3)
> (From update of attachment 70023 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=70023&action=review
> 
> > WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp:232
> > +    // Make sure the context has a DOMWindow global object, otherwise this context didn't originate from a View.
> 
> I'm not sure if View with a capital V refers to a class or a named concept. Maybe this comment could be improved.

You are right, when we are talking in WebKit2 terms that should be a Page. In WebKit1 terms that is a WebView. I will correct the comment.

Thanks for the review!

Jessie
Comment 5 Jessie Berlin 2010-10-07 07:59:13 PDT 
Comment on attachment 70023 [details]
Add InjectedBundle::reportException

Comitted in r69309
http://trac.webkit.org/changeset/69309