Bug 46768 - Paint the plug-in backing store into the WebProcess backing store
Summary: Paint the plug-in backing store into the WebProcess backing store
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-28 17:05 PDT by Anders Carlsson
Modified: 2010-09-28 17:14 PDT (History)
0 users

See Also:

Attachments
Patch (15.94 KB, patch)
2010-09-28 17:07 PDT, Anders Carlsson 		sam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2010-09-28 17:05:00 PDT 
Paint the plug-in backing store into the WebProcess backing store
Comment 1 Anders Carlsson 2010-09-28 17:07:19 PDT 
Created attachment 69138 [details]
Patch
Comment 2 Sam Weinig 2010-09-28 17:11:52 PDT 
Comment on attachment 69138 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=69138&action=review

> WebKit2/WebKit2Prefix.h:47
>  // FIXME: Enable once this works well enough.
> -#define ENABLE_PLUGIN_PROCESS 0
> +#define ENABLE_PLUGIN_PROCESS 1

Was this intentional?

> WebKit2/WebProcess/Plugins/PluginProxy.cpp:115
> +    CGContextRef platformContext = graphicsContext->platformContext();
> +    CGContextSaveGState(platformContext);

This should be removed. You never even restore the GState.
Comment 3 Anders Carlsson 2010-09-28 17:14:14 PDT 
Committed r68612: <http://trac.webkit.org/changeset/68612>