Web Inspector: a number of breakpoints for one line

[Ilya Tikhonovsky]

1) start chromium
2) open inspector
3) press pause
4) move mouse over inspected page
5) debugger will stop on mouseover listener
6) make a breakpoint
7) close inspector
8) open inspector

expected:
single breakpoint

actual:
multiple breakpoints for one line.

[Pavel Podivilov]

Created attachment 69612 [details]
Proposed patch.

[Joseph Pecoraro]

Comment on attachment 69612 [details]
Proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=69612&action=review

> WebCore/bindings/v8/DebuggerScript.js:103
> +    if (!locations.length)
> +      return undefined;
> +    var actualLineNumber = locations[0].line;

Looks like incorrect whitespace on the 2nd line. Would be great if this was fixed.

[Pavel Podivilov]

Committed r69019: <http://trac.webkit.org/changeset/69019>

[Pavel Podivilov]

(In reply to comment #2)
> (From update of attachment 69612 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=69612&action=review
> 
> > WebCore/bindings/v8/DebuggerScript.js:103
> > +    if (!locations.length)
> > +      return undefined;
> > +    var actualLineNumber = locations[0].line;
> 
> Looks like incorrect whitespace on the 2nd line. Would be great if this was fixed.

Sure, thanks for correction, Joe!

[Joseph Pecoraro]

(In reply to comment #4)
> Sure, thanks for correction, Joe!

Thanks for making the fix and landing manually!