Bug 46744 - [Qt] Text drawing taints GraphicsContext's QPainter::pen()
Summary: [Qt] Text drawing taints GraphicsContext's QPainter::pen()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: QtWebKit Unassigned
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks:
 
Reported: 2010-09-28 12:03 PDT by Andreas Kling
Modified: 2010-09-28 12:56 PDT (History)
3 users (show)

See Also:

Attachments
Proposed patch (5.88 KB, patch)
2010-09-28 12:04 PDT, Andreas Kling 		kenneth: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2010-09-28 12:03:28 PDT 
Drawing text currently replaces the GC's pen.
This means that using canvas's strokeText() will make the canvas context's strokeStyle lose sync with the GC's pen.
Comment 1 Andreas Kling 2010-09-28 12:04:57 PDT 
Created attachment 69082 [details]
Proposed patch
Comment 2 Kenneth Rohde Christiansen 2010-09-28 12:07:21 PDT 
Comment on attachment 69082 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=69082&action=review

LGTM

> WebCore/platform/graphics/qt/FontQt.cpp:212
> +        QPen oldPen = p->pen();

Persoannly I like previousPen better than old.
Comment 3 Andreas Kling 2010-09-28 12:19:59 PDT 
Committed r68549: <http://trac.webkit.org/changeset/68549>
Comment 4 WebKit Review Bot 2010-09-28 12:56:55 PDT 
http://trac.webkit.org/changeset/68549 might have broken SnowLeopard Intel Release (Tests)