Bug 46737 - Implement PluginProxy::destroy
Summary: Implement PluginProxy::destroy
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-28 10:52 PDT by Anders Carlsson
Modified: 2010-09-28 11:12 PDT (History)
0 users

See Also:

Attachments
Patch (8.07 KB, patch)
2010-09-28 10:55 PDT, Anders Carlsson 		aroben: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2010-09-28 10:52:14 PDT 
Implement PluginProxy::destroy
Comment 1 Anders Carlsson 2010-09-28 10:55:36 PDT 
Created attachment 69071 [details]
Patch
Comment 2 Adam Roben (:aroben) 2010-09-28 11:01:52 PDT 
Comment on attachment 69071 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=69071&action=review

> WebKit2/PluginProcess/WebProcessConnection.messages.in:30
> +    # Destroys the plug-in instance with the given instance ID.
> +    DestroyPlugin(uint64_t pluginInstanceID) -> ()

I worry that this doesn't make it clear enough that this is a sync message. Maybe we need to make the syntax more explicit.
Comment 3 Adam Roben (:aroben) 2010-09-28 11:02:12 PDT 
Comment on attachment 69071 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=69071&action=review

> WebKit2/ChangeLog:14
> +        * PluginProcess/WebProcessConnection.cpp:
> +        (WebKit::WebProcessConnection::destroyPluginControllerProxy):
> +        Rename this to avoid conflicts with the destroyPlugin message handler.

C++ overloading should make this a non-issue.
Comment 4 Anders Carlsson 2010-09-28 11:12:28 PDT 
Committed r68545: <http://trac.webkit.org/changeset/68545>