RESOLVED FIXED 46737
Implement PluginProxy::destroy 
https://bugs.webkit.org/show_bug.cgi?id=46737
Summary Implement PluginProxy::destroy
Anders Carlsson
Reported 2010-09-28 10:52:14 PDT
Implement PluginProxy::destroy
Attachments
Patch (8.07 KB, patch)
2010-09-28 10:55 PDT, Anders Carlsson 		aroben: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2010-09-28 10:55:36 PDT
Created attachment 69071 [details] Patch
Adam Roben (:aroben)
Comment 2 2010-09-28 11:01:52 PDT
Comment on attachment 69071 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=69071&action=review > WebKit2/PluginProcess/WebProcessConnection.messages.in:30 > + # Destroys the plug-in instance with the given instance ID. > + DestroyPlugin(uint64_t pluginInstanceID) -> () I worry that this doesn't make it clear enough that this is a sync message. Maybe we need to make the syntax more explicit.
Adam Roben (:aroben)
Comment 3 2010-09-28 11:02:12 PDT
Comment on attachment 69071 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=69071&action=review > WebKit2/ChangeLog:14 > + * PluginProcess/WebProcessConnection.cpp: > + (WebKit::WebProcessConnection::destroyPluginControllerProxy): > + Rename this to avoid conflicts with the destroyPlugin message handler. C++ overloading should make this a non-issue.
Anders Carlsson
Comment 4 2010-09-28 11:12:28 PDT
Committed r68545: <http://trac.webkit.org/changeset/68545>
Note You need to log in before you can comment on or make changes to this bug.